Implementing preload=metadata for video

webkit/glue/webmediaplayer_impl.cc

Index: webkit/glue/webmediaplayer_impl.cc
diff --git a/webkit/glue/webmediaplayer_impl.cc b/webkit/glue/webmediaplayer_impl.cc
index 54bc600d461fb31c159f0ad9cef13696eb1f7491..c64b3d9e0700aba427c0cbe792703b4b60cd0054 100644
--- a/webkit/glue/webmediaplayer_impl.cc
+++ b/webkit/glue/webmediaplayer_impl.cc
@@ -382,6 +382,8 @@ void WebMediaPlayerImpl::load(const WebKit::WebURL& url) {
 
   // Handle any volume changes that occured before load().
   setVolume(GetClient()->volume());
+  // Get the preload value.
+  setPreload(static_cast<WebMediaPlayer::Preload>(GetClient()->preload()));

[acolwell GONE FROM CHROMIUM, 2011/03/25 04:35:28]

What is the type of the enum we are casting from? Do we have 3 enums we have to
keep in sync?

[vrk (LEFT CHROMIUM), 2011/03/25 21:33:32]

Oops, I think this is a mistake because of a mistake in my WebKit interface.
Will update in the next patch.

 
   // Initialize the pipeline.
   SetNetworkState(WebKit::WebMediaPlayer::Loading);
@@ -495,10 +497,12 @@ void WebMediaPlayerImpl::setVisible(bool visible) {
   return;
 }
 
-bool WebMediaPlayerImpl::setAutoBuffer(bool autoBuffer) {
+bool WebMediaPlayerImpl::setPreload(WebKit::WebMediaPlayer::Preload preload) {
   DCHECK(MessageLoop::current() == main_loop_);
 
-  return false;
+  pipeline_->SetPreload(static_cast<media::Preload>(preload));
+
+  return true;

[acolwell GONE FROM CHROMIUM, 2011/03/25 04:35:28]

Why is the return value changing?

[vrk (LEFT CHROMIUM), 2011/03/25 21:33:32]

Actually I don't think the return value is used or needed (other than "bool" is
needed to comply with WebKit side of things). I will update the WebKit patch,
then this patch accordingly.

 }
 
 bool WebMediaPlayerImpl::totalBytesKnown() {