Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: media/base/pipeline_impl.h

Issue 6625059: Implementing preload=metadata for video (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup defer strategy, fix logic bug Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/pipeline_impl.h
diff --git a/media/base/pipeline_impl.h b/media/base/pipeline_impl.h
index 32de091261b5ecf273fed113f80c16e059354955..ba461e94ebd4115cc5ee6ed9907eb658734819fb 100644
--- a/media/base/pipeline_impl.h
+++ b/media/base/pipeline_impl.h
@@ -114,6 +114,8 @@ class PipelineImpl : public Pipeline, public FilterHost {
virtual void SetPlaybackRate(float playback_rate);
virtual float GetVolume() const;
virtual void SetVolume(float volume);
+ virtual Preload GetPreload() const;
acolwell GONE FROM CHROMIUM 2011/03/25 04:35:28 Move to private section since this isn't part of t
vrk (LEFT CHROMIUM) 2011/03/25 21:33:32 Done.
+ virtual void SetPreload(Preload preload);
virtual base::TimeDelta GetCurrentTime() const;
virtual base::TimeDelta GetBufferedTime();
virtual base::TimeDelta GetMediaDuration() const;
@@ -240,6 +242,9 @@ class PipelineImpl : public Pipeline, public FilterHost {
// Carries out notifying filters that the volume has changed.
void VolumeChangedTask(float volume);
+ // Carries out notifying filters that the preload value has changed.
+ void PreloadChangedTask(Preload preload);
+
// Carries out notifying filters that we are seeking to a new timestamp.
void SeekTask(base::TimeDelta time, PipelineStatusCallback* seek_callback);
@@ -355,6 +360,11 @@ class PipelineImpl : public Pipeline, public FilterHost {
// filters.
float volume_;
+ // Current value of preload attribute. This value is set immediately via
+ // SetPreload() and a task is dispatched on the message loop to notify the
+ // filters.
+ Preload preload_;
+
// Current playback rate (>= 0.0f). This value is set immediately via
// SetPlaybackRate() and a task is dispatched on the message loop to notify
// the filters.
@@ -423,6 +433,9 @@ class PipelineImpl : public Pipeline, public FilterHost {
scoped_refptr<AudioRenderer> audio_renderer_;
scoped_refptr<VideoRenderer> video_renderer_;
+ // Demuxer reference used for setting the preload value.
+ scoped_refptr<Demuxer> demuxer_;
+
// Helper class that stores filter references during pipeline
// initialization.
class PipelineInitState;

Powered by Google App Engine
This is Rietveld 408576698