Implementing preload=metadata for video

media/base/filters.h

Index: media/base/filters.h
diff --git a/media/base/filters.h b/media/base/filters.h
index d6b962d64bb4775857662f3bbb62059ba10326a2..ba4f422e919838216f3b29c78a666c049887c35f 100644
--- a/media/base/filters.h
+++ b/media/base/filters.h
@@ -43,6 +43,13 @@ class FilterHost;
 
 struct PipelineStatistics;
 
+// Used to specify video preload states.

[acolwell GONE FROM CHROMIUM, 2011/03/25 04:35:28]

You should add a note here that this enum must match the WebKit enum especially
if you use static_cast instead of a mapping function.

A reference to the HTTP spec or a description of the meanings of each value
might be good.

[vrk (LEFT CHROMIUM), 2011/03/25 21:33:32]

Done.

+enum Preload {
+  PRELOAD_NONE,
+  PRELOAD_METADATA,
+  PRELOAD_AUTO,
+};
+
 // Used for completing asynchronous methods.
 typedef Callback0::Type FilterCallback;
 
@@ -127,6 +134,9 @@ class DataSource : public Filter {
   // Returns true if we are performing streaming. In this case seeking is
   // not possible.
   virtual bool IsStreaming() = 0;
+
+  // Alert the DataSource that the video preload value has been changed.
+  virtual void SetPreload(Preload preload);

[acolwell GONE FROM CHROMIUM, 2011/03/25 04:35:28]

Make this pure virtual like the other methods.

[vrk (LEFT CHROMIUM), 2011/03/25 21:33:32]

Done.

 };
 
 class DemuxerStream : public base::RefCountedThreadSafe<DemuxerStream> {
@@ -180,6 +190,9 @@ class Demuxer : public Filter {
  public:
   // Returns the given stream type, or NULL if that type is not present.
   virtual scoped_refptr<DemuxerStream> GetStream(DemuxerStream::Type type) = 0;
+
+  // Alert the Demuxer that the video preload value has been changed.
+  virtual void SetPreload(Preload preload);

[acolwell GONE FROM CHROMIUM, 2011/03/25 04:35:28]

Make this pure virtual like the other method so implementers are forced to think
about this.

[vrk (LEFT CHROMIUM), 2011/03/25 21:33:32]

Done.

 };