Implementing preload=metadata for video

webkit/glue/webmediaplayer_impl.cc

Index: webkit/glue/webmediaplayer_impl.cc
diff --git a/webkit/glue/webmediaplayer_impl.cc b/webkit/glue/webmediaplayer_impl.cc
index 54bc600d461fb31c159f0ad9cef13696eb1f7491..25b3c9b7006b0bb214527395b759c1d7c30a6e5d 100644
--- a/webkit/glue/webmediaplayer_impl.cc
+++ b/webkit/glue/webmediaplayer_impl.cc
@@ -382,6 +382,8 @@ void WebMediaPlayerImpl::load(const WebKit::WebURL& url) {
 
   // Handle any volume changes that occured before load().
   setVolume(GetClient()->volume());
+  // Get the preload value.
+  setPreload(GetClient()->preload());
 
   // Initialize the pipeline.
   SetNetworkState(WebKit::WebMediaPlayer::Loading);
@@ -495,10 +497,10 @@ void WebMediaPlayerImpl::setVisible(bool visible) {
   return;
 }
 
-bool WebMediaPlayerImpl::setAutoBuffer(bool autoBuffer) {
+void WebMediaPlayerImpl::setPreload(WebKit::WebMediaPlayer::Preload preload) {
   DCHECK(MessageLoop::current() == main_loop_);
 
-  return false;
+  pipeline_->SetPreload(static_cast<media::Preload>(preload));

[acolwell GONE FROM CHROMIUM, 2011/03/29 05:52:03]

This just makes me nervous. Can we just put a switch here w/o default: so that
any new values added to WebKit::WebMediaPlayer::Preload will cause a compile
error? I just want to make sure we are protected from subtle bugs if WebKit
decides to reverse alphabetize the constants or something. ;)

[vrk (LEFT CHROMIUM), 2011/03/30 17:41:44]

Agreed! Added compile-time asserts.

 }
 
 bool WebMediaPlayerImpl::totalBytesKnown() {