Implementing preload=metadata for video

webkit/glue/webmediaplayer_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/webmediaplayer_impl.h"
 
 #include <limits>
 #include <string>
 
 #include "base/callback.h"
@@ skipping 364 matching lines @@
     filter_collection_->SelectVideoDecoder(&old_videodecoder);
     media::RTCVideoDecoder* rtc_video_decoder =
         new media::RTCVideoDecoder(
              message_loop_factory_->GetMessageLoop("VideoDecoderThread"),
              url.spec());
     filter_collection_->AddVideoDecoder(rtc_video_decoder);
   }
 
   // Handle any volume changes that occured before load().
   setVolume(GetClient()->volume());
+  // Get the preload value.
+  setPreload(static_cast<WebMediaPlayer::Preload>(GetClient()->preload()));

[acolwell GONE FROM CHROMIUM, 2011/03/25 04:35:28]

What is the type of the enum we are casting from? Do we have 3 enums we have to
keep in sync?

[vrk (LEFT CHROMIUM), 2011/03/25 21:33:32]

Oops, I think this is a mistake because of a mistake in my WebKit interface.
Will update in the next patch.

 
   // Initialize the pipeline.
   SetNetworkState(WebKit::WebMediaPlayer::Loading);
   SetReadyState(WebKit::WebMediaPlayer::HaveNothing);
   pipeline_->Start(
       filter_collection_.release(),
       url.spec(),
       NewCallback(proxy_.get(),
                   &WebMediaPlayerImpl::Proxy::PipelineInitializationCallback));
 }
@@ skipping 93 matching lines @@
   pipeline_->SetVolume(volume);
 }
 
 void WebMediaPlayerImpl::setVisible(bool visible) {
   DCHECK(MessageLoop::current() == main_loop_);
 
   // TODO(hclam): add appropriate method call when pipeline has it implemented.
   return;
 }
 
-bool WebMediaPlayerImpl::setAutoBuffer(bool autoBuffer) {
+bool WebMediaPlayerImpl::setPreload(WebKit::WebMediaPlayer::Preload preload) {
   DCHECK(MessageLoop::current() == main_loop_);
 
-  return false;
+  pipeline_->SetPreload(static_cast<media::Preload>(preload));
+
+  return true;

[acolwell GONE FROM CHROMIUM, 2011/03/25 04:35:28]

Why is the return value changing?

[vrk (LEFT CHROMIUM), 2011/03/25 21:33:32]

Actually I don't think the return value is used or needed (other than "bool" is
needed to comply with WebKit side of things). I will update the WebKit patch,
then this patch accordingly.

 }
 
 bool WebMediaPlayerImpl::totalBytesKnown() {
   DCHECK(MessageLoop::current() == main_loop_);
 
   return pipeline_->GetTotalBytes() != 0;
 }
 
 bool WebMediaPlayerImpl::hasVideo() const {
   DCHECK(MessageLoop::current() == main_loop_);
@@ skipping 395 matching lines @@
   }
 }
 
 WebKit::WebMediaPlayerClient* WebMediaPlayerImpl::GetClient() {
   DCHECK(MessageLoop::current() == main_loop_);
   DCHECK(client_);
   return client_;
 }
 
 }  // namespace webkit_glue