media/filters/file_data_source.cc - Issue 6625059: Implementing preload=metadata for video

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/filters/file_data_source.cc

Issue 6625059: Implementing preload=metadata for video (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing enums Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <limits>	5 #include <limits>

6	6

7 #include "base/file_util.h"	7 #include "base/file_util.h"

8 #include "base/logging.h"	8 #include "base/logging.h"

9 #include "base/utf_string_conversions.h"	9 #include "base/utf_string_conversions.h"

10 #include "media/base/filter_host.h"	10 #include "media/base/filter_host.h"

(...skipping 98 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
109 DCHECK(file_);	109 DCHECK(file_);

110 base::AutoLock l(lock_);	110 base::AutoLock l(lock_);

111 *size_out = file_size_;	111 *size_out = file_size_;

112 return (NULL != file_);	112 return (NULL != file_);

113 }	113 }

114	114

115 bool FileDataSource::IsStreaming() {	115 bool FileDataSource::IsStreaming() {

116 return false;	116 return false;

117 }	117 }

118	118

	119 void FileDataSource::SetPreload(Preload preload) {
	scherkus (not reviewing) 2011/03/31 23:40:21 nit: empty methods should be {} if it's a one-line nit: empty methods should be {} if it's a one-liner vrk (LEFT CHROMIUM) 2011/04/01 22:52:12 Done. Show quoted text On 2011/03/31 23:40:21, scherkus wrote: > nit: empty methods should be {} if it's a one-liner Done.
	120 }

	121

119 } // namespace media	122 } // namespace media

OLD	NEW

« no previous file with comments | « media/filters/file_data_source.h ('k') | webkit/glue/media/buffered_data_source.h » ('j') | webkit/glue/media/buffered_data_source.cc » ('J')