Issue 6625054: Make the typefeedback oracle use a NumberDictionary instead of JSObject as it...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6625054: Make the typefeedback oracle use a NumberDictionary instead of JSObject as it... (Closed)

Created:
9 years, 9 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make the typefeedback oracle use a NumberDictionary instead of JSObject as its backing store. This avoids problems when getters/setters are defined on Object. BUG=v8:1232 Committed: http://code.google.com/p/v8/source/detail?r=7081

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -28 lines)			Patch
	M	src/type-info.h	View		2 chunks	+5 lines, -3 lines	0 comments	Download
	M	src/type-info.cc	View	1	7 chunks	+38 lines, -25 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

9 years, 9 months ago (2011-03-07 13:49:45 UTC) #2

LGTM

http://codereview.chromium.org/6625054/diff/1/src/type-info.cc
File src/type-info.cc (right):

http://codereview.chromium.org/6625054/diff/1/src/type-info.cc#newcode330
src/type-info.cc:330: for (int i = 0; i < length; i++) {
You may want a loop HandleScope to avoid using too many handles if length is
long.
Can it be long?

http://codereview.chromium.org/6625054/diff/1/src/type-info.cc#newcode373
src/type-info.cc:373: dictionary_ = Factory::DictionaryAtNumberPut(dictionary_,
It seems almost all branches end in a dictionary put with the same dictionary
and position.
Could you just remember the value in a variable, and have one common put-call at
the end?

Expand Messages | Collapse Messages