Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 6625038: Enhance logging_UserCrash to detect problems with crash reporting setup (Closed)

Created:
9 years, 9 months ago by Sonny
Modified:
9 years ago
Reviewers:
kmixter1
CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli
Visibility:
Public.

Description

Enhance logging_UserCrash to detect problems with crash reporting setup This is to help catch problems like the recent one where the core pattern sysctl wasn't being set up correctly. logging_UserCrash would override the pattern for it's testing and wouldn't see that no crash reports would actually get generated. BUG=chromium-os:12627 TEST=run logging_UserCrash with a known good core pattern and a known bad pattern Change-Id: I15d1fc11a77ef8eb586a4166f5da851a4cc65624 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3142372

Patch Set 1 #

Patch Set 2 : Detect bad core pattern in logging_UserCrash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M client/site_tests/logging_UserCrash/logging_UserCrash.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sonny
9 years, 9 months ago (2011-03-05 05:21:39 UTC) #1
Sonny
9 years, 9 months ago (2011-03-05 05:22:23 UTC) #2
kmixter1
9 years, 9 months ago (2011-03-08 01:20:51 UTC) #3
LGTM

On Fri, Mar 4, 2011 at 9:22 PM, <sonnyrao@chromium.org> wrote:

> http://codereview.chromium.org/6625038/
>

Powered by Google App Engine
This is Rietveld 408576698