Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 6625035: Fix breakage in ctest.py. (Closed)

Created:
9 years, 9 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
Benson Leung, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Fix breakage in ctest.py. Spotted the following error on the bots: Traceback (most recent call last): File "bin/ctest", line 318, in <module> main() File "bin/ctest", line 314, in main options.remote, not options.cache) TypeError: RunAUTestHarness() takes exactly 9 arguments (8 given) http://chromeos-botmaster.mtv.corp.google.com:8026/builders/x86%20AGZ%20Full/builds/545/steps/cbuild/logs/stdio ( http://bit.ly/fdwOq1 ) This change fixes the error introduced in b54301bb9a284302d0f82c12a8753c3302a86d88. TEST=Verify that new argument is passed through. BUG=chromium-os:12211 Change-Id: Ibe8ee2f1fd0001525a5699a9dc107730f9c181de Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7a05e06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M bin/ctest.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
davidjames
9 years, 9 months ago (2011-03-05 03:11:16 UTC) #1
Benson Leung
On 2011/03/05 03:11:16, davidjames wrote: LGTM.
9 years, 9 months ago (2011-03-05 03:14:32 UTC) #2
sosa
9 years, 9 months ago (2011-03-05 05:25:35 UTC) #3
Thanks so much!
 On Mar 4, 2011 7:14 PM, <bleung@chromium.org> wrote:
> On 2011/03/05 03:11:16, davidjames wrote:
>
> LGTM.
>
> http://codereview.chromium.org/6625035/

Powered by Google App Engine
This is Rietveld 408576698