Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: ppapi/cpp/dev/fullscreen_dev.cc

Issue 6625034: Clarify/fix fullscreen semantics, and add GetScreenSize (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix review comments Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/cpp/dev/fullscreen_dev.h ('k') | ppapi/proxy/ppapi_messages_internal.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/dev/fullscreen_dev.cc
diff --git a/ppapi/cpp/dev/fullscreen_dev.cc b/ppapi/cpp/dev/fullscreen_dev.cc
index e68b2962c0f05ca2b14f4ee361f51a23127e8a10..11bb09a6b9a9bcb22b7ca27db4fdd764d5c55025 100644
--- a/ppapi/cpp/dev/fullscreen_dev.cc
+++ b/ppapi/cpp/dev/fullscreen_dev.cc
@@ -9,6 +9,7 @@
#include "ppapi/cpp/instance.h"
#include "ppapi/cpp/module.h"
#include "ppapi/cpp/module_impl.h"
+#include "ppapi/cpp/size.h"
namespace pp {
@@ -21,7 +22,7 @@ template <> const char* interface_name<PPB_Fullscreen_Dev>() {
} // namespace
Fullscreen_Dev::Fullscreen_Dev(Instance* instance)
- : associated_instance_(instance) {
+ : instance_(instance) {
}
Fullscreen_Dev::~Fullscreen_Dev() {
@@ -30,14 +31,21 @@ Fullscreen_Dev::~Fullscreen_Dev() {
bool Fullscreen_Dev::IsFullscreen() {
return has_interface<PPB_Fullscreen_Dev>() &&
get_interface<PPB_Fullscreen_Dev>()->IsFullscreen(
- associated_instance_->pp_instance());
+ instance_->pp_instance());
}
bool Fullscreen_Dev::SetFullscreen(bool fullscreen) {
if (!has_interface<PPB_Fullscreen_Dev>())
return false;
return PPBoolToBool(get_interface<PPB_Fullscreen_Dev>()->SetFullscreen(
- associated_instance_->pp_instance(), BoolToPPBool(fullscreen)));
+ instance_->pp_instance(), BoolToPPBool(fullscreen)));
+}
+
+bool Fullscreen_Dev::GetScreenSize(Size* size) {
+ if (!has_interface<PPB_Fullscreen_Dev>())
+ return false;
+ return PPBoolToBool(get_interface<PPB_Fullscreen_Dev>()->GetScreenSize(
+ instance_->pp_instance(), &size->pp_size()));
}
} // namespace pp
« no previous file with comments | « ppapi/cpp/dev/fullscreen_dev.h ('k') | ppapi/proxy/ppapi_messages_internal.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698