Clarify/fix fullscreen semantics, and add GetScreenSize

webkit/plugins/ppapi/ppb_graphics_2d_impl.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppb_graphics_2d_impl.h"
 
 #include <iterator>
 
 #include "base/logging.h"
 #include "base/message_loop.h"
@@ skipping 441 matching lines @@
   if (bound_instance_ == new_instance)
     return true;  // Rebinding the same device, nothing to do.
   if (bound_instance_ && new_instance)
     return false;  // Can't change a bound device.
 
   if (!new_instance) {
     // When the device is detached, we'll not get any more paint callbacks so
     // we need to clear the list, but we still want to issue any pending
     // callbacks to the plugin.
     if (!unpainted_flush_callback_.is_null()) {
-      ScheduleOffscreenCallback(unpainted_flush_callback_);
+      FlushCallbackData callback;
+      std::swap(callback, unpainted_flush_callback_);
       unpainted_flush_callback_.Clear();

[viettrungluu, 2011/03/08 00:06:01]

Is this Clear() really needed?

[piman, 2011/03/08 00:55:30]

Done.

+      ScheduleOffscreenCallback(callback);
     }
     if (!painted_flush_callback_.is_null()) {
-      ScheduleOffscreenCallback(painted_flush_callback_);
+      FlushCallbackData callback;
+      std::swap(callback, painted_flush_callback_);
       painted_flush_callback_.Clear();

[viettrungluu, 2011/03/08 00:06:01]

"

[piman, 2011/03/08 00:55:30]

Done.

+      ScheduleOffscreenCallback(callback);
     }
   } else if (flushed_any_data_) {
     // Only schedule a paint if this backing store has had any data flushed to
     // it. This is an optimization. A "normal" plugin will first allocated a
     // backing store, bind it, and then execute their normal painting and
     // update loop. If binding a device always invalidated, it would mean we
     // would get one paint for the bind, and one for the first time the plugin
     // actually painted something. By not bothering to schedule an invalidate
     // when an empty device is initially bound, we can save an extra paint for
     // many plugins during the critical page initialization phase.
@@ skipping 194 matching lines @@
 
 bool PPB_Graphics2D_Impl::HasPendingFlush() const {
   return !unpainted_flush_callback_.is_null() ||
          !painted_flush_callback_.is_null() ||
          offscreen_flush_pending_;
 }
 
 }  // namespace ppapi
 }  // namespace webkit