Clarify/fix fullscreen semantics, and add GetScreenSize

chrome/renderer/render_widget_fullscreen_pepper.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/render_widget_fullscreen_pepper.h"
 
 #include "chrome/common/render_messages.h"
 #include "chrome/renderer/ggl/ggl.h"
 #include "chrome/renderer/gpu_channel_host.h"
 #include "chrome/renderer/pepper_platform_context_3d_impl.h"
@@ skipping 45 matching lines @@
     widget_->Invalidate();
   }
 
   virtual void animate() {
   }
 
   virtual void layout() {
   }
 
   virtual void paint(WebCanvas* canvas, const WebRect& rect) {
-    if (!plugin_)
-      return;
     WebRect plugin_rect(0, 0, size_.width, size_.height);
     plugin_->Paint(canvas, plugin_rect, rect);
   }
 
   virtual void composite(bool finish) {
     ggl::Context* context = widget_->context();
     DCHECK(context);
     gpu::gles2::GLES2Implementation* gl = ggl::GetImplementation(context);
     unsigned int texture = plugin_->GetBackingTextureId();
     gl->BindTexture(GL_TEXTURE_2D, texture);
     gl->DrawArrays(GL_TRIANGLES, 0, 3);
     ggl::SwapBuffers(context);
   }
 
   virtual void themeChanged() {
     NOTIMPLEMENTED();
   }
 
   virtual bool handleInputEvent(const WebInputEvent& event) {
-    if (!plugin_)
-      return false;
     return plugin_->HandleInputEvent(event, &cursor_);
   }
 
   virtual void mouseCaptureLost() {
     NOTIMPLEMENTED();
   }
 
   virtual void setFocus(bool focus) {
     NOTIMPLEMENTED();
   }
 
+  // TODO(piman): figure out IME and implement these if necessary.

[viettrungluu, 2011/03/08 00:06:01]

Does leaving in the NOTIMPLEMENTED()s result in a lot of spew?

[piman, 2011/03/08 00:55:30]

Yes, 2 per frame when in full-screen, including in release, so I removed them.

   virtual bool setComposition(
       const WebString& text,
       const WebVector<WebCompositionUnderline>& underlines,
       int selectionStart,
       int selectionEnd) {
-    NOTIMPLEMENTED();
     return false;
   }
 
   virtual bool confirmComposition() {
-    NOTIMPLEMENTED();
     return false;
   }
 
   virtual bool confirmComposition(const WebString& text) {
-    NOTIMPLEMENTED();
     return false;
   }
 
   virtual WebTextInputType textInputType() {
-    NOTIMPLEMENTED();
     return WebKit::WebTextInputTypeNone;
   }
 
   virtual WebRect caretOrSelectionBounds() {
-    NOTIMPLEMENTED();
     return WebRect();
   }
 
   virtual void setTextDirection(WebTextDirection) {
-    NOTIMPLEMENTED();
   }
 
   virtual bool isAcceleratedCompositingActive() const {
-    return widget_->context() && plugin_ &&
-        (plugin_->GetBackingTextureId() != 0);
+    return widget_->context() && (plugin_->GetBackingTextureId() != 0);
   }
 
  private:
-  webkit::ppapi::PluginInstance* plugin_;
+  scoped_refptr<webkit::ppapi::PluginInstance> plugin_;
   RenderWidgetFullscreenPepper* widget_;
   WebSize size_;
   WebCursorInfo cursor_;
 
   DISALLOW_COPY_AND_ASSIGN(PepperWidget);
 };
 
 }  // anonymous namespace
 
 // static
@@ skipping 65 matching lines @@
 }
 
 void RenderWidgetFullscreenPepper::DidFlushPaint() {
   if (plugin_)
     plugin_->ViewFlushedPaint();
 }
 
 void RenderWidgetFullscreenPepper::Close() {
   // If the fullscreen window is closed (e.g. user pressed escape), reset to
   // normal mode.
   if (plugin_)

[viettrungluu, 2011/03/08 00:06:01]

Why do you sometimes check |plugin_| and sometimes not?

[piman, 2011/03/08 00:55:30]

The RenderWidgetFullscreenPepper checks for it because it can be set back to
NULL from RenderWidgetFullscreenPepper::Destroy.
The PepperWidget doesn't need to though, because it always keeps a reference to
the plugin.

-    plugin_->SetFullscreen(false);
+    plugin_->SetFullscreen(false, false);
 }
 
 webkit::ppapi::PluginInstance*
 RenderWidgetFullscreenPepper::GetBitmapForOptimizedPluginPaint(
     const gfx::Rect& paint_bounds,
     TransportDIB** dib,
     gfx::Rect* location,
     gfx::Rect* clip) {
   if (plugin_ &&
       plugin_->GetBitmapForOptimizedPluginPaint(paint_bounds, dib,
@@ skipping 159 matching lines @@
   return true;
 }
 
 bool RenderWidgetFullscreenPepper::CheckCompositing() {
   bool compositing = webwidget_->isAcceleratedCompositingActive();
   if (compositing != is_accelerated_compositing_active_) {
     didActivateAcceleratedCompositing(compositing);
   }
   return compositing;
 }