safe_browsing::PrefixSet persistence code.

safe_browsing::PrefixSet persistence code.

Just the ability to read/write the data structure to a file.  File
format is a simple header, the contents of the vectors, and a
checksum.

BUG=71832
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77314

[Scott Hess - ex-Googler, 2011-03-04 02:01:12]

Apologies for the poor diffs on Baseline and Empty tests.

[Scott Hess - ex-Googler, 2011-03-07 20:54:52]

No wonder I wasn't getting a response on this - I never sent it for review!

[Scott Hess - ex-Googler, 2011-03-08 01:26:41]

thanks!

http://codereview.chromium.org/6625002/diff/2002/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/prefix_set.cc (right):

http://codereview.chromium.org/6625002/diff/2002/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/prefix_set.cc:190: // Read |deltas_|.
On 2011/03/08 01:15:51, lzheng wrote:
> I guess there should be no "_" in deltas_ in above comment.

Reworded this and the index comment slightly.

http://codereview.chromium.org/6625002/diff/2002/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/prefix_set.h (right):

http://codereview.chromium.org/6625002/diff/2002/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/prefix_set.h:86: // Helper for |LoadFile()|. 
Steals the contents of |index| and
On 2011/03/08 01:15:51, lzheng wrote:
> Are there two spaces between "." and "Steals?"

Yeah?  All my prose has two spaces after sentence-ending punctuation.

http://codereview.chromium.org/6625002/diff/2002/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/prefix_set_unittest.cc (right):

http://codereview.chromium.org/6625002/diff/2002/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/prefix_set_unittest.cc:41: // Check that all
elements pf |prefixes| are in |prefix_set|, and
On 2011/03/08 01:15:51, lzheng wrote:
> pf -> of?

'pf' is a well-known alternative spelling, but I can see how that might be
confusing.  Done.

http://codereview.chromium.org/6625002/diff/2002/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/prefix_set_unittest.cc:82: }
On 2011/03/08 01:15:51, lzheng wrote:
> empty line needed here.

Done.

[lzheng, 2011-03-08 18:28:53]

LGTM