Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 6624091: Fix Issue 1234. (Closed)

Created:
9 years, 9 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Fix Issue 1234. Ensure that there is always enough bytes between consequtive calls in unoptimized code to write a call instruction at the return points without overlapping. This handles the case where two return points were only four bytes apart (because the latter call was to a register). BUG=v8:1234 Committed: http://code.google.com/p/v8/source/detail?r=7089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -44 lines) Patch
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/safepoint-table.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +12 lines, -13 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 7 chunks +39 lines, -14 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 11 chunks +36 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
9 years, 9 months ago (2011-03-08 09:13:45 UTC) #1
Rico
LGTM if we add a regression test. In addition, are we sure that this never ...
9 years, 9 months ago (2011-03-08 10:25:37 UTC) #2
Lasse Reichstein
9 years, 9 months ago (2011-03-08 10:41:33 UTC) #3
We have an assertion in the deoptimizer.
It might be worth it to add checks to the code-generator, so that we can catch
the problem even if don't try to deoptimize.

Powered by Google App Engine
This is Rietveld 408576698