Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 6624086: Force sync integration try jobs on patches that touch sync dependencies (Closed)

Created:
9 years, 9 months ago by Raghu Simha
Modified:
9 years, 7 months ago
Reviewers:
akalin
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Force sync integration try jobs on patches that touch sync dependencies Chrome sync is dependent on other areas of chrome, and patches committed to these areas could potentially break sync. In the past, we have seen sync integration test failures caused by patches to net, jingle and base. This patch adds a PRESUBMIT.py file to each of these directories, that will result the sync integration tests being run on any code that touches these directories as part of their try runs. BUG=70311 TEST=modify something under base, net or jingle and do a "git try" or "gcl try" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
A base/PRESUBMIT.py View 1 chunk +13 lines, -0 lines 0 comments Download
A jingle/PRESUBMIT.py View 1 chunk +13 lines, -0 lines 0 comments Download
A net/PRESUBMIT.py View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Raghu Simha
Fred, please review.
9 years, 9 months ago (2011-03-08 03:23:30 UTC) #1
akalin
9 years, 9 months ago (2011-03-08 03:33:55 UTC) #2
LGTM

On 2011/03/08 03:23:30, rsimha wrote:
> Fred, please review.

Powered by Google App Engine
This is Rietveld 408576698