Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 6624034: Formatting the readmes in deps to follow the proper format and making sure th... (Closed)

Created:
9 years, 9 months ago by Cris Neckar
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews
Visibility:
Public.

Description

Formatting the readmes in deps to follow the proper format and making sure they contain Short Name and Version fields for version tracking. BUG=None TEST=N/A Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78071

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -7 lines) Patch
M third_party/drmemory/README.chromium View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/ffmpeg/README.chromium View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/flac/README.chromium View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/hunspell/README.chromium View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/icu46/README.chromium View 1 2 3 4 5 6 7 1 chunk +3 lines, -1 line 0 comments Download
M third_party/libjpeg_turbo/README.chromium View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libsrtp/README.chromium View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libunwind/README.chromium View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libvpx/README.chromium View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/mingw/README.chromium View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/nasm/README.chromium View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/nss/README.chromium View 1 2 3 4 5 6 7 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/openssl/README.chromium View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M third_party/pthreads-win32/README.chromium View 1 2 3 4 5 6 7 1 chunk +4 lines, -1 line 0 comments Download
M third_party/speex/README.chromium View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/tsan/README.chromium View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/valgrind/README.chromium View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/xdg-utils/README.chromium View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/xulrunner-sdk/README.chromium View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A third_party/xz/README.chromium View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/yasm/README.chromium View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Cris Neckar
I'll also be adding a presubmit rule to ensure that people are following the template ...
9 years, 9 months ago (2011-03-04 22:36:23 UTC) #1
Evan Martin
Why add all the "Description:" lines? What does Version = 0 mean? What Version should ...
9 years, 9 months ago (2011-03-04 22:39:36 UTC) #2
Cris Neckar
> Why add all the "Description:" lines? I added these for parsability and sanity. We ...
9 years, 9 months ago (2011-03-14 18:11:22 UTC) #3
Evan Martin
On 2011/03/14 18:11:22, cdn wrote: > > Why add all the "Description:" lines? > I ...
9 years, 9 months ago (2011-03-14 18:44:36 UTC) #4
Evan Martin
9 years, 9 months ago (2011-03-14 18:44:50 UTC) #5
oops, didn't actually mark the one

http://codereview.chromium.org/6624034/diff/4001/third_party/ffmpeg/README.ch...
File third_party/ffmpeg/README.chromium (right):

http://codereview.chromium.org/6624034/diff/4001/third_party/ffmpeg/README.ch...
third_party/ffmpeg/README.chromium:3: 
This one doesn't have a "Description:" part.

Powered by Google App Engine
This is Rietveld 408576698