Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 6624027: Rename BrowserFrameGtk::Init to BFG::InitBrowserFrame. (Closed)

Created:
9 years, 9 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, davemoore+watch_chromium.org
Visibility:
Public.

Description

Rename BrowserFrameGtk::Init to BFG::InitBrowserFrame. This makes it clear it's not an intended override of WidgetGtk::Init. BUG=70465, 72205 TEST=none TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76961

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/chromeos/frame/browser_frame_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/frame/browser_frame_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
9 years, 9 months ago (2011-03-04 20:13:01 UTC) #1
sky
Can you do the same change to browser_frame_win too.
9 years, 9 months ago (2011-03-04 20:33:10 UTC) #2
Nico
Done. On Fri, Mar 4, 2011 at 12:33 PM, <sky@chromium.org> wrote: > Can you do ...
9 years, 9 months ago (2011-03-04 20:37:08 UTC) #3
sky
9 years, 9 months ago (2011-03-04 21:15:45 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698