Issue 6624026: libcros: fix up DBus signatures of new async routines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6624026: libcros: fix up DBus signatures of new async routines (Closed)

Created:
9 years, 9 months ago by Nathan Williams

Modified:
9 years, 6 months ago

Reviewers:
stevenjb

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/cros.git@master

Visibility:
Public.

Description

NetworkServiceConnectAsync(): Don't pass the path as an argument - it's implicit in the object (proxy) we're invoking the method on. SetNetworkServiceProperty: Pass G_TYPE_VALUE instead of the inner type of the value object. Change-Id: I421cafaf11a4fea988a1656cd026968f9db0461e BUG=None TEST=Call from Chrome network_library.cc Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ae8c8e4

Patch Set 1 #

Patch Set 2 : Fix a similar signature botch in SetNetworkServiceProperty #

Patch Set 3 : Rebase #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	chromeos_network.cc	View	1 2	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stevenjb

9 years, 9 months ago (2011-03-05 02:03:30 UTC) #2

Oh, hey, you already found this :) I must have missed the email.

LGTM

Expand Messages | Collapse Messages