Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: net/base/connection_type_histograms.cc

Issue 6624023: Skip generation of stats, since code is now shared across threads (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/connection_type_histograms.cc
===================================================================
--- net/base/connection_type_histograms.cc (revision 76254)
+++ net/base/connection_type_histograms.cc (working copy)
@@ -21,6 +21,11 @@
// Each histogram has an unused bucket at the end to allow seamless future
// expansion.
void UpdateConnectionTypeHistograms(ConnectionType type) {
+ // TODO(wtc): Bug 74467 Move these stats up to a higher level, where the
+ // explicit static (shown below) and the implicit statics (inside the
+ // HISTOGRAM macros) will be thread safe.
+#if 0 // Don't do anything for now.
+
static bool had_connection_type[NUM_OF_CONNECTION_TYPES];
if (type >= 0 && type < NUM_OF_CONNECTION_TYPES) {
@@ -35,6 +40,7 @@
} else {
NOTREACHED(); // Someone's logging an invalid type!
}
+#endif // 0
}
} // namespace net
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698