Skip generation of stats, since code is now shared across threads

net/base/connection_type_histograms.cc

Index: net/base/connection_type_histograms.cc
===================================================================
--- net/base/connection_type_histograms.cc	(revision 76254)
+++ net/base/connection_type_histograms.cc	(working copy)
@@ -5,6 +5,7 @@
 #include "net/base/connection_type_histograms.h"
 
 #include "base/metrics/histogram.h"
+#include "content/browser/browser_thread.h"
 
 namespace net {
 
@@ -22,6 +23,7 @@
 // expansion.
 void UpdateConnectionTypeHistograms(ConnectionType type) {
   static bool had_connection_type[NUM_OF_CONNECTION_TYPES];
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

[willchan no longer on Chromium, 2011/03/04 19:15:34]

Unfortunately, net/ is not aware of browser stuff. This is a layering violation.

Oh, I see the bug thread now. The sync code is running from a different thread
(the sync thread) and it uses TCPClientSocketLibevent. So yes, I guess this code
here is definitely racy.

 
   if (type >= 0 && type < NUM_OF_CONNECTION_TYPES) {
     if (!had_connection_type[type]) {