Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "net/base/connection_type_histograms.h" | 5 #include "net/base/connection_type_histograms.h" |
| 6 | 6 |
| 7 #include "base/metrics/histogram.h" | 7 #include "base/metrics/histogram.h" |
| 8 | 8 |
| 9 namespace net { | 9 namespace net { |
| 10 | 10 |
| 11 // We're using a histogram as a group of counters. We're only interested in | 11 // We're using a histogram as a group of counters. We're only interested in |
| 12 // the values of the counters. Ignore the shape, average, and standard | 12 // the values of the counters. Ignore the shape, average, and standard |
| 13 // deviation of the histograms because they are meaningless. | 13 // deviation of the histograms because they are meaningless. |
| 14 // | 14 // |
| 15 // We use two groups of counters. In the first group (counter1), each counter | 15 // We use two groups of counters. In the first group (counter1), each counter |
| 16 // is a boolean (0 or 1) that indicates whether the user has seen a connection | 16 // is a boolean (0 or 1) that indicates whether the user has seen a connection |
| 17 // of that type during that session. In the second group (counter2), each | 17 // of that type during that session. In the second group (counter2), each |
| 18 // counter is the number of connections of that type the user has seen during | 18 // counter is the number of connections of that type the user has seen during |
| 19 // that session. | 19 // that session. |
| 20 // | 20 // |
| 21 // Each histogram has an unused bucket at the end to allow seamless future | 21 // Each histogram has an unused bucket at the end to allow seamless future |
| 22 // expansion. | 22 // expansion. |
| 23 void UpdateConnectionTypeHistograms(ConnectionType type) { | 23 void UpdateConnectionTypeHistograms(ConnectionType type) { |
| 24 // TODO(wtc): 74467 Move these stats up to a higher level, where the explicit | |
|
wtc
2011/03/04 21:05:24
Nit: please add "bug" before "74467".
| |
| 25 // static (shown below) and the implicit statics (inside the HISTOGRAM macros) | |
| 26 // will be safe. | |
| 27 #if 0 // Don't do anything for now. | |
| 28 | |
| 24 static bool had_connection_type[NUM_OF_CONNECTION_TYPES]; | 29 static bool had_connection_type[NUM_OF_CONNECTION_TYPES]; |
| 25 | 30 |
| 26 if (type >= 0 && type < NUM_OF_CONNECTION_TYPES) { | 31 if (type >= 0 && type < NUM_OF_CONNECTION_TYPES) { |
| 27 if (!had_connection_type[type]) { | 32 if (!had_connection_type[type]) { |
| 28 had_connection_type[type] = true; | 33 had_connection_type[type] = true; |
| 29 UMA_HISTOGRAM_ENUMERATION("Net.HadConnectionType3", | 34 UMA_HISTOGRAM_ENUMERATION("Net.HadConnectionType3", |
| 30 type, NUM_OF_CONNECTION_TYPES); | 35 type, NUM_OF_CONNECTION_TYPES); |
| 31 } | 36 } |
| 32 | 37 |
| 33 UMA_HISTOGRAM_ENUMERATION("Net.ConnectionTypeCount3", | 38 UMA_HISTOGRAM_ENUMERATION("Net.ConnectionTypeCount3", |
| 34 type, NUM_OF_CONNECTION_TYPES); | 39 type, NUM_OF_CONNECTION_TYPES); |
| 35 } else { | 40 } else { |
| 36 NOTREACHED(); // Someone's logging an invalid type! | 41 NOTREACHED(); // Someone's logging an invalid type! |
| 37 } | 42 } |
| 43 #endif // 0 | |
| 38 } | 44 } |
| 39 | 45 |
| 40 } // namespace net | 46 } // namespace net |
| OLD | NEW |