presubmit_canned_checks.py - Issue 6623074: add changes to presubmit needed for OWNERS support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 6623074: add changes to presubmit needed for OWNERS support (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: update w/ review feedback from maruel; still needs tests Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 6523ec605cd57f0ba1b28fd60b0e6a0396787dec..20751581e2284dc2d8a73b3b4c47e6b292124223 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -642,5 +642,4 @@ def CheckOwners(input_api, output_api, source_file_filter=None):

return []

suggested_reviewers = owners_db.ReviewersFor(affected_files)

- # TODO(dpranke): Actually propagate the info back.

- return []

+ return [output_api.PresubmitAddText('R=%s' % ','.join(suggested_reviewers))]