| OLD | NEW |
|---|
| 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Generic presubmit checks that can be reused by other presubmit checks.""" | 5 """Generic presubmit checks that can be reused by other presubmit checks.""" |
| 6 | 6 |
| 7 ### Description checks | 7 ### Description checks |
| 8 | 8 |
| 9 def CheckChangeHasTestField(input_api, output_api): | 9 def CheckChangeHasTestField(input_api, output_api): |
| 10 """Requires that the changelist have a TEST= field.""" | 10 """Requires that the changelist have a TEST= field.""" |
| (...skipping 624 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 635 missing_files = owners_db.FilesNotCoveredBy(affected_files, | 635 missing_files = owners_db.FilesNotCoveredBy(affected_files, |
| 636 input_api.change.approvers) | 636 input_api.change.approvers) |
| 637 if missing_files: | 637 if missing_files: |
| 638 return [output_api.PresubmitPromptWarning('Missing approvals for: %s' % | 638 return [output_api.PresubmitPromptWarning('Missing approvals for: %s' % |
| 639 ','.join(missing_files))] | 639 ','.join(missing_files))] |
| 640 return [] | 640 return [] |
| 641 elif input_api.change.tags.get('R'): | 641 elif input_api.change.tags.get('R'): |
| 642 return [] | 642 return [] |
| 643 | 643 |
| 644 suggested_reviewers = owners_db.ReviewersFor(affected_files) | 644 suggested_reviewers = owners_db.ReviewersFor(affected_files) |
| 645 # TODO(dpranke): Actually propagate the info back. | 645 return [output_api.PresubmitAddText('R=%s' % ','.join(suggested_reviewers))] |
| 646 return [] | |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 6623074:
add changes to presubmit needed for OWNERS support (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools