add changes to presubmit needed for OWNERS support

add PresubmitAddText() result class to indicate that text needs to be passed back to git cl / gcl.

Also, this properly wires up the presubmit code to the owners code and adds unit tests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77523

[M-A Ruel, 2011-03-08 19:58:32]

Need some testing though

http://codereview.chromium.org/6623074/diff/1/git_cl/git_cl.py
File git_cl/git_cl.py (right):

http://codereview.chromium.org/6623074/diff/1/git_cl/git_cl.py#newcode56
git_cl/git_cl.py:56: def RunCommand(cmd, error_ok=False, error_message=None,
I want to merge this code into gclient_utils.CheckCallAndFilter() eventually.
For now it could be sufficient.

http://codereview.chromium.org/6623074/diff/1/git_cl/git_cl.py#newcode495
git_cl/git_cl.py:495: """First stab at a framework for letting hooks alter what
happens next.
Can you define what it is instead?

Same for ChangeDescription

http://codereview.chromium.org/6623074/diff/1/git_cl/git_cl.py#newcode511
git_cl/git_cl.py:511: for l in output_from_hooks.split('\n'):
splitlines()

http://codereview.chromium.org/6623074/diff/1/git_cl/git_cl.py#newcode514
git_cl/git_cl.py:514: self.reviewers = m.group(1)
What about multiple R= lines?

http://codereview.chromium.org/6623074/diff/1/presubmit_support.py
File presubmit_support.py (right):

http://codereview.chromium.org/6623074/diff/1/presubmit_support.py#newcode158
presubmit_support.py:158: """Propagate a line of text back to the caller."""
Propagates

[Dirk Pranke, 2011-03-08 22:26:03]

http://codereview.chromium.org/6623074/diff/1/git_cl/git_cl.py
File git_cl/git_cl.py (right):

http://codereview.chromium.org/6623074/diff/1/git_cl/git_cl.py#newcode56
git_cl/git_cl.py:56: def RunCommand(cmd, error_ok=False, error_message=None,
On 2011/03/08 19:58:32, Marc-Antoine Ruel wrote:
> I want to merge this code into gclient_utils.CheckCallAndFilter() eventually.
> For now it could be sufficient.

I agree that would be good. I can look at doing that in a separate patch if you
like.

http://codereview.chromium.org/6623074/diff/1/git_cl/git_cl.py#newcode495
git_cl/git_cl.py:495: """First stab at a framework for letting hooks alter what
happens next.
On 2011/03/08 19:58:32, Marc-Antoine Ruel wrote:
> Can you define what it is instead?
> 
> Same for ChangeDescription

Will do.

http://codereview.chromium.org/6623074/diff/1/git_cl/git_cl.py#newcode511
git_cl/git_cl.py:511: for l in output_from_hooks.split('\n'):
On 2011/03/08 19:58:32, Marc-Antoine Ruel wrote:
> splitlines()

I wasn't sure if this was a builtin on strings, and the docs I looked at lied to
me. Will change.

http://codereview.chromium.org/6623074/diff/1/git_cl/git_cl.py#newcode514
git_cl/git_cl.py:514: self.reviewers = m.group(1)
On 2011/03/08 19:58:32, Marc-Antoine Ruel wrote:
> What about multiple R= lines?

Obviously, this version doesn't support that. I'm not sure how common that is in
practice, but there doesn't seem to be any downside and it's trivial to add, so
I will add it.

[M-A Ruel, 2011-03-08 22:40:59]

http://codereview.chromium.org/6623074/diff/8001/git_cl/git_cl.py
File git_cl/git_cl.py (right):

http://codereview.chromium.org/6623074/diff/8001/git_cl/git_cl.py#newcode501
git_cl/git_cl.py:501: def print_output(self):
Is this function useful? I don't see it being used.

[Dirk Pranke, 2011-03-08 23:42:44]

removed PrintOutput, rebased, still needs tests.

[Dirk Pranke, 2011-03-09 02:24:16]

Okay, to simplify things I'm splitting the git cl changes out into a separate
patch, so this patch just has the changes to the presubmit* files, and it adds
unit tests.

[M-A Ruel, 2011-03-09 02:33:23]

lgtm