Support mixed allocation in browser vs subprocesses...

Support mixed allocation in browser vs subprocesses

Continue to support selection of a browser allocator
selection via the environment variable CHROME_ALLOCATOR,
and also add CHROME_ALLOCATOR_2 that can select the
allocator to use in subprocesses, such as a renderer.

Temporarilly set the browser default to the
default windows heap allocator, and the subprocess
allocator to TCMalloc to help detect memory corruption
in a cannary for a few days.

Add minor cleanup (removing reserved word "override"
etc.).


r=mbelshe
bug=74901
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77207

[Mike Belshe, 2011-03-07 22:37:16]

lgtm

http://codereview.chromium.org/6623059/diff/1006/base/allocator/allocator_shi...
File base/allocator/allocator_shim.cc (right):

http://codereview.chromium.org/6623059/diff/1006/base/allocator/allocator_shi...
base/allocator/allocator_shim.cc:290: getenv_s(&secondary_length, buffer,
sizeof(buffer), secondary_name);
nit: not sure if this API provides null termination when size > buffer_size

[jar (doing other things), 2011-03-07 22:45:07]

Changes per review by mbelshe.

http://codereview.chromium.org/6623059/diff/1006/base/allocator/allocator_shi...
File base/allocator/allocator_shim.cc (right):

http://codereview.chromium.org/6623059/diff/1006/base/allocator/allocator_shi...
base/allocator/allocator_shim.cc:290: getenv_s(&secondary_length, buffer,
sizeof(buffer), secondary_name);
On 2011/03/07 22:37:16, Mike Belshe wrote:
> nit: not sure if this API provides null termination when size > buffer_size

Added safety net null termination (especially since it currently works, but
documentation incorrectly says stuff, like the result includes value AND
name!?!?).  It is hard to tell what "real API" is.

Thanks!!!