Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 6623030: Call firmware wipe script during factory wipe if it exists (Closed)

Created:
9 years, 9 months ago by Stefan Reinauer
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Call firmware wipe script during factory wipe if it exists BUG=chrome-os-partner:2183 TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ce6c671

Patch Set 1 #

Total comments: 2

Patch Set 2 : drop use of variables that are not available in the context of this script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M clobber-state View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nick Sanders
http://codereview.chromium.org/6623030/diff/1/clobber-state File clobber-state (right): http://codereview.chromium.org/6623030/diff/1/clobber-state#newcode118 clobber-state:118: if [ "$DEVMODE" = "1" -o -f /root/.dev_mode ]; ...
9 years, 9 months ago (2011-03-05 04:46:43 UTC) #1
Nick Sanders
You can test this by writing echo "factory fast" > /mnt/stateful_partition/factory_install_reset then reboot
9 years, 9 months ago (2011-03-05 04:50:45 UTC) #2
Stefan Reinauer
On 2011/03/05 04:46:43, Nick Sanders wrote: > http://codereview.chromium.org/6623030/diff/1/clobber-state > File clobber-state (right): > > http://codereview.chromium.org/6623030/diff/1/clobber-state#newcode118 ...
9 years, 9 months ago (2011-03-05 04:56:46 UTC) #3
Nick Sanders
lgtm
9 years, 9 months ago (2011-03-05 06:39:13 UTC) #4
Stefan Reinauer
9 years, 9 months ago (2011-03-05 08:35:12 UTC) #5
tested and works. yay.

Powered by Google App Engine
This is Rietveld 408576698