Issue 6623026: Refactor site_fmap, flashrom_utils and gbb_utils module into client/cros.

Issue 6623026: Refactor site_fmap, flashrom_utils and gbb_utils module into client/cros. (Closed)

Created:
9 years, 9 months ago by ericli

Modified:
9 years, 7 months ago

Reviewers:
Hung-Te

CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli

Base URL:
ssh://git@gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

Refactor site_fmap, flashrom_util and gbb_util module into client/cros. Change-Id: I69da43763f17189ad8c5c447d4db69e13378b0ce BUG=chromium-os:12633 TEST=grep the entire autotest repo and find out all source code which has site_fmap, flashrom_util and gbb_util and changed them. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c5b74af

Patch Set 1 #

Total comments: 2

Patch Set 2 : patch #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -18 lines)			Patch
A +	client/cros/flashrom_util.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	client/cros/fmap.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	client/cros/gbb_util.py	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	client/site_tests/factory_EnableWriteProtect/factory_EnableWriteProtect.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	client/site_tests/factory_LogVpd/factory_LogVpd.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	client/site_tests/factory_WriteGBB/factory_WriteGBB.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	client/site_tests/firmware_RomSize/firmware_RomSize.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	client/site_tests/hardware_Components/firmware_hash.py	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	client/site_tests/hardware_Components/hardware_Components.py	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	client/site_tests/hardware_EepromWriteProtect/hardware_EepromWriteProtect.py	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hung-Te

http://codereview.chromium.org/6623026/diff/1/client/cros/flashrom_util.py File client/cros/flashrom_util.py (right): http://codereview.chromium.org/6623026/diff/1/client/cros/flashrom_util.py#newcode255 client/cros/flashrom_util.py:255: import site_fmap here we use site_fmap, too. please change ...

9 years, 9 months ago (2011-03-05 02:58:59 UTC) #2

ericli

PTAL. http://codereview.chromium.org/6623026/diff/1/client/cros/flashrom_util.py File client/cros/flashrom_util.py (right): http://codereview.chromium.org/6623026/diff/1/client/cros/flashrom_util.py#newcode255 client/cros/flashrom_util.py:255: import site_fmap On 2011/03/05 02:58:59, Hung-Te wrote: > ...

9 years, 9 months ago (2011-03-07 17:47:03 UTC) #3

Hung-Te

9 years, 9 months ago (2011-03-08 01:33:11 UTC) #4

LGTM, thanks.

Before you commit the change, please:
1. site_fmap.py (and maybe even gbb_util/flashrom_util, not sure) has been
changed on ToT. Please make sure you have synced the latest  version.
2. please do a grep -Ril 'fmap = fmap' to make sure we won't get name conflicts
by removing site_ prefix

Expand Messages | Collapse Messages