Make more methods on Widget non-virtual and move to NativeWidget...

views/widget/widget.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_WIDGET_WIDGET_H_
 #define VIEWS_WIDGET_WIDGET_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 76 matching lines @@
                                    EventsParam accept_events,
                                    DeleteParam delete_on_destroy,
                                    MirroringParam mirror_in_rtl);
 
   // Enumerates all windows pertaining to us and notifies their
   // view hierarchies that the locale has changed.
   static void NotifyLocaleChanged();
 
   Widget();
 
+  // Unconverted methods -------------------------------------------------------
+
+  // TODO(beng):
+  // Widget subclasses are still implementing these methods by overriding from
+  // here rather than by implementing NativeWidget.
+
   // Initialize the Widget with a parent and an initial desired size.
   // |contents_view| is the view that will be the single child of RootView
   // within this Widget. As contents_view is inserted into RootView's tree,
   // RootView assumes ownership of this view and cleaning it up. If you remove
   // this view, you are responsible for its destruction. If this value is NULL,
   // the caller is responsible for populating the RootView, and sizing its
   // contents as the window is sized.
   virtual void Init(gfx::NativeView parent, const gfx::Rect& bounds);
   virtual void InitWithWidget(Widget* parent, const gfx::Rect& bounds);
 
+  // Returns the gfx::NativeView associated with this Widget.
+  virtual gfx::NativeView GetNativeView() const;
+
+  // Starts a drag operation for the specified view. |point| is a position in
+  // |view| coordinates that the drag was initiated from.
+  virtual void GenerateMousePressedForView(View* view,
+                                           const gfx::Point& point);
+
+  // Returns the accelerator given a command id. Returns false if there is
+  // no accelerator associated with a given id, which is a common condition.
+  virtual bool GetAccelerator(int cmd_id, ui::Accelerator* accelerator);
+
+  // Returns the Window containing this Widget, or NULL if not contained in a
+  // window.
+  virtual Window* GetWindow();
+  virtual const Window* GetWindow() const;
+
+  // Forwarded from the RootView so that the widget can do any cleanup.
+  virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child);
+
+  // Converted methods ---------------------------------------------------------
+
+  // TODO(beng):
+  // Widget subclasses are implementing these methods by implementing
+  // NativeWidget. Remove this comment once complete.
+
   // Returns the topmost Widget in a hierarchy. Will return NULL if called
   // before the underlying Native Widget has been initialized.
   Widget* GetTopLevelWidget();
   const Widget* GetTopLevelWidget() const;
 
   // Gets/Sets the WidgetDelegate.
   WidgetDelegate* widget_delegate() const { return widget_delegate_; }
   void set_widget_delegate(WidgetDelegate* widget_delegate) {
     widget_delegate_ = widget_delegate;
   }
 
   // Sets the specified view as the contents of this Widget. There can only
   // be one contents view child of this Widget's RootView. This view is sized to
   // fit the entire size of the RootView. The RootView takes ownership of this
   // View, unless it is set as not being parent-owned.
   void SetContentsView(View* view);
 
   // Returns the bounds of the Widget in screen coordinates.
   gfx::Rect GetWindowScreenBounds() const;
 
   // Returns the bounds of the Widget's client area in screen coordinates.
   gfx::Rect GetClientAreaScreenBounds() const;
 
   // Sizes and/or places the widget to the specified bounds, size or position.
-  virtual void SetBounds(const gfx::Rect& bounds);
+  void SetBounds(const gfx::Rect& bounds);
 
   // Places the widget in front of the specified widget in z-order.
-  virtual void MoveAbove(Widget* widget);
+  void MoveAbove(Widget* widget);
 
   // Sets a shape on the widget. This takes ownership of shape.
-  virtual void SetShape(gfx::NativeRegion shape);
+  void SetShape(gfx::NativeRegion shape);
 
   // Hides the widget then closes it after a return to the message loop.
-  virtual void Close();
+  void Close();
 
+  // TODO(beng): Move off public API.
   // Closes the widget immediately. Compare to |Close|. This will destroy the
   // window handle associated with this Widget, so should not be called from
   // any code that expects it to be valid beyond this call.
-  virtual void CloseNow();
+  void CloseNow();
 
   // Shows or hides the widget, without changing activation state.
-  virtual void Show();
-  virtual void Hide();
-
-  // Returns the gfx::NativeView associated with this Widget.
-  virtual gfx::NativeView GetNativeView() const;
+  void Show();
+  void Hide();
 
   // Sets the opacity of the widget. This may allow widgets behind the widget
   // in the Z-order to become visible, depending on the capabilities of the
   // underlying windowing system. Note that the caller must then schedule a
   // repaint to allow this change to take effect.
-  virtual void SetOpacity(unsigned char opacity);
+  void SetOpacity(unsigned char opacity);
 
   // Sets the widget to be on top of all other widgets in the windowing system.
-  virtual void SetAlwaysOnTop(bool on_top);
+  void SetAlwaysOnTop(bool on_top);
 
   // Returns the RootView contained by this Widget.
-  virtual RootView* GetRootView();
+  RootView* GetRootView();
 
   // Returns whether the Widget is visible to the user.
-  virtual bool IsVisible() const;
+  bool IsVisible() const;
 
   // Returns whether the Widget is the currently active window.
-  virtual bool IsActive() const;
+  bool IsActive() const;
 
   // Returns whether the Widget is customized for accessibility.
-  virtual bool IsAccessibleWidget() const;
-
-  // Starts a drag operation for the specified view. |point| is a position in
-  // |view| coordinates that the drag was initiated from.
-  virtual void GenerateMousePressedForView(View* view,
-                                           const gfx::Point& point);
-
-  // Returns the accelerator given a command id. Returns false if there is
-  // no accelerator associated with a given id, which is a common condition.
-  virtual bool GetAccelerator(int cmd_id, ui::Accelerator* accelerator);
-
-  // Returns the Window containing this Widget, or NULL if not contained in a
-  // window.
-  virtual Window* GetWindow();
-  virtual const Window* GetWindow() const;
+  bool IsAccessibleWidget() const;
 
   // Returns the ThemeProvider that provides theme resources for this Widget.
   virtual ThemeProvider* GetThemeProvider() const;
 
   // Returns the FocusManager for this widget.
   // Note that all widgets in a widget hierarchy share the same focus manager.
+  // TODO(beng): remove virtual.
   virtual FocusManager* GetFocusManager();
 
-  // Forwarded from the RootView so that the widget can do any cleanup.
-  virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child);
-
   // Returns true if the native view |native_view| is contained in the
   // views::View hierarchy rooted at this widget.
   // TODO(beng): const.
   bool ContainsNativeView(gfx::NativeView native_view);
 
   // Starts a drag operation for the specified view. This blocks until the drag
   // operation completes. |view| can be NULL.
   // If the view is non-NULL it can be accessed during the drag by calling
   // dragged_view(). If the view has not been deleted during the drag,
   // OnDragDone() is called on it.
   void RunShellDrag(View* view, const ui::OSExchangeData& data, int operation);
 
   // Returns the view that requested the current drag operation via
   // RunShellDrag(), or NULL if there is no such view or drag operation.
   View* dragged_view() { return dragged_view_; }
 
   // Adds the specified |rect| in client area coordinates to the rectangle to be
   // redrawn.
   void SchedulePaintInRect(const gfx::Rect& rect);
 
   // Sets the currently visible cursor. If |cursor| is NULL, the cursor used
   // before the current is restored.
   void SetCursor(gfx::NativeCursor cursor);
 
   // Retrieves the focus traversable for this widget.
-  virtual FocusTraversable* GetFocusTraversable();
+  FocusTraversable* GetFocusTraversable();
 
   // Notifies the view hierarchy contained in this widget that theme resources
   // changed.
   void ThemeChanged();
 
   // Notifies the view hierarchy contained in this widget that locale resources
   // changed.
   void LocaleChanged();
 
   void SetFocusTraversableParent(FocusTraversable* parent);
@@ skipping 57 matching lines @@
   // Valid for the lifetime of RunShellDrag(), indicates the view the drag
   // started from.
   View* dragged_view_;
 
   DISALLOW_COPY_AND_ASSIGN(Widget);
 };
 
 }  // namespace views
 
 #endif // VIEWS_WIDGET_WIDGET_H_