Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: views/view.cc

Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/view.cc
diff --git a/views/view.cc b/views/view.cc
index bd778c645dc4be75f170912a6f0bafd83bc82ae2..7a8a7202eca48c19824ffcf103b124bc03858bc0 100644
--- a/views/view.cc
+++ b/views/view.cc
@@ -48,6 +48,15 @@ char View::kViewClassName[] = "views/View";
void View::SetHotTracked(bool flag) {
}
+bool View::IsHotTracked() const {
+ return false;
+}
+
+// FATE TBD --------------------------------------------------------------------
+
+Widget* View::child_widget() {
+ return NULL;
+}
// Creation and lifetime -------------------------------------------------------
@@ -340,6 +349,10 @@ void View::SetVisible(bool flag) {
}
}
+bool View::IsVisible() const {
+ return is_visible_;
+}
+
bool View::IsVisibleInRootView() const {
return IsVisible() && parent() ? parent()->IsVisibleInRootView() : false;
}
@@ -544,6 +557,10 @@ int View::GetGroup() const {
return group_;
}
+bool View::IsGroupFocusTraversable() const {
+ return true;
+}
+
void View::GetViewsWithGroup(int group_id, std::vector<View*>* out) {
if (group_ == group_id)
out->push_back(this);
@@ -864,6 +881,10 @@ void View::ResetAccelerators() {
UnregisterAccelerators(false);
}
+bool View::AcceleratorPressed(const Accelerator& accelerator) {
+ return false;
+}
+
// Focus -----------------------------------------------------------------------
bool View::HasFocus() {
@@ -903,6 +924,10 @@ bool View::IsAccessibilityFocusableInRootView() const {
IsVisibleInRootView();
}
+void View::set_accessibility_focusable(bool accessibility_focusable) {
+ accessibility_focusable_ = accessibility_focusable;
+}
+
FocusManager* View::GetFocusManager() {
Widget* widget = GetWidget();
return widget ? widget->GetFocusManager() : NULL;
@@ -914,6 +939,18 @@ void View::RequestFocus() {
focus_manager->SetFocusedView(this);
}
+bool View::SkipDefaultKeyEventProcessing(const KeyEvent& e) {
+ return false;
+}
+
+FocusTraversable* View::GetFocusTraversable() {
+ return NULL;
+}
+
+FocusTraversable* View::GetPaneFocusTraversable() {
+ return NULL;
+}
+
// Tooltips --------------------------------------------------------------------
bool View::GetTooltipText(const gfx::Point& p, std::wstring* tooltip) {
@@ -991,6 +1028,14 @@ void View::NotifyAccessibilityEvent(AccessibilityTypes::Event event_type) {
NotifyAccessibilityEvent(event_type, true);
}
+string16 View::GetAccessibleDefaultAction() {
+ return string16();
+}
+
+string16 View::GetAccessibleKeyboardShortcut() {
+ return string16();
+}
+
bool View::GetAccessibleName(string16* name) {
DCHECK(name);
@@ -1004,6 +1049,14 @@ AccessibilityTypes::Role View::GetAccessibleRole() {
return AccessibilityTypes::ROLE_CLIENT;
}
+AccessibilityTypes::State View::GetAccessibleState() {
+ return 0;
+}
+
+string16 View::GetAccessibleValue() {
+ return string16();
+}
+
void View::SetAccessibleName(const string16& name) {
accessible_name_ = name;
}
« views/controls/menu/menu_host_gtk.h ('K') | « views/view.h ('k') | views/views.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698