Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3512)

Unified Diff: chrome/browser/ui/views/tabs/tab_renderer_data.h

Issue 6622002: Do all OOLing in the views code. linux_views now builds clean with the clang plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/tab_renderer_data.h
diff --git a/chrome/browser/ui/views/tabs/tab_renderer_data.h b/chrome/browser/ui/views/tabs/tab_renderer_data.h
index 43962dfdffce15bfd2219219a9c91a50fc2f4464..28b55fcca416ef1b859d679f0093014d2fb5640b 100644
--- a/chrome/browser/ui/views/tabs/tab_renderer_data.h
+++ b/chrome/browser/ui/views/tabs/tab_renderer_data.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -21,16 +21,8 @@ struct TabRendererData {
NETWORK_STATE_LOADING, // connected, transferring data.
};
- TabRendererData()
- : network_state(NETWORK_STATE_NONE),
- loading(false),
- crashed_status(base::TERMINATION_STATUS_STILL_RUNNING),
- off_the_record(false),
- show_icon(true),
- mini(false),
- blocked(false),
- app(false) {
- }
+ TabRendererData();
+ ~TabRendererData();
// This interprets the crashed status to decide whether or not this
// render data represents a tab that is "crashed" (i.e. the render
@@ -43,21 +35,7 @@ struct TabRendererData {
// Returns true if the TabRendererData is same as given |data|. Two favicons
// are considered equals if two SkBitmaps point to the same SkPixelRef object.
- bool Equals(const TabRendererData& data) {
- return
- favicon.pixelRef() &&
- favicon.pixelRef() == data.favicon.pixelRef() &&
- favicon.pixelRefOffset() == data.favicon.pixelRefOffset() &&
- network_state == data.network_state &&
- title == data.title &&
- loading == data.loading &&
- crashed_status == data.crashed_status &&
- off_the_record == data.off_the_record &&
- show_icon == data.show_icon &&
- mini == data.mini &&
- blocked == data.blocked &&
- app == data.app;
- }
+ bool Equals(const TabRendererData& data);
SkBitmap favicon;
NetworkState network_state;

Powered by Google App Engine
This is Rietveld 408576698