Do all OOLing in the views code. linux_views now builds clean with the clang plugin.

views/window/dialog_client_view.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_WINDOW_DIALOG_CLIENT_VIEW_H_
 #define VIEWS_WINDOW_DIALOG_CLIENT_VIEW_H_
 #pragma once
 
 #include "ui/gfx/font.h"
 #include "views/focus/focus_manager.h"
@@ skipping 50 matching lines @@
 
   // Overridden from View:
   virtual void NativeViewHierarchyChanged(bool attached,
                                           gfx::NativeView native_view,
                                           RootView* root_view);
 
   // Overridden from ClientView:
   virtual bool CanClose();
   virtual void WindowClosing();
   virtual int NonClientHitTest(const gfx::Point& point);
-  virtual DialogClientView* AsDialogClientView() { return this; }
+  virtual DialogClientView* AsDialogClientView();
 
   // FocusChangeListener implementation:
   virtual void FocusWillChange(View* focused_before, View* focused_now);
 
  protected:
   // View overrides:
   virtual void OnPaint(gfx::Canvas* canvas);
   virtual void PaintChildren(gfx::Canvas* canvas);
   virtual void Layout();
   virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child);
@@ skipping 69 matching lines @@
 
   // Static resource initialization
   static gfx::Font* dialog_button_font_;
 
   DISALLOW_COPY_AND_ASSIGN(DialogClientView);
 };
 
 }  // namespace views
 
 #endif  // #ifndef VIEWS_WINDOW_DIALOG_CLIENT_VIEW_H_