Issue 6621071: X64 Crankshaft: Add inline one-element cache for Instanceof.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6621071: X64 Crankshaft: Add inline one-element cache for Instanceof. (Closed)

Created:
9 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 Crankshaft: Add inline one-element cache for Instanceof. Committed: http://code.google.com/p/v8/source/detail?r=7109

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -35 lines)			Patch
M	src/x64/code-stubs-x64.cc	View	1 2	4 chunks	+95 lines, -24 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2	2 chunks	+42 lines, -7 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 9 months ago (2011-03-09 15:21:53 UTC) #2

LGTM

http://codereview.chromium.org/6621071/diff/8/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

http://codereview.chromium.org/6621071/diff/8/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:3670: static const int kOffsetToResultValue = 21;
Please comment on what instructions these words represent.

http://codereview.chromium.org/6621071/diff/8/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:3673: // None of the flags are supported on X64.
This comment seems no longer valid. None -> Some? Args in registers not
supported - right?

http://codereview.chromium.org/6621071/diff/8/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:3781: __ movl(rax, Immediate(0xB8));  // TrueValue is
at -9 * kPointerSize.
TrueValue -> FalseValue

Expand Messages | Collapse Messages