Refactor sync notifier out of sync api.

chrome/browser/sync/notifier/sync_notifier.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Interface to the sync notifier.

[akalin, 2011/03/10 04:26:45]

Expand this comment, maybe something like:

Interface for a sync notifier, which is an object that receives notifications
when updates are available for a set of sync types.

[Agrawal, 2011/03/11 01:13:07]

Done.

+
+#ifndef CHROME_BROWSER_SYNC_NOTIFIER_SYNC_NOTIFIER_H_
+#define CHROME_BROWSER_SYNC_NOTIFIER_SYNC_NOTIFIER_H_
+
+#include <string>
+
+#include "chrome/browser/sync/notifier/sync_notifier_observer.h"

[akalin, 2011/03/10 04:26:45]

forward-declare SyncNotifierObserver

[Agrawal, 2011/03/11 01:13:07]

Done.

+#include "chrome/browser/sync/syncable/model_type.h"
+
+namespace sync_notifier {
+
+class SyncNotifier {
+ public:
+  SyncNotifier() {}
+  virtual ~SyncNotifier() {}
+
+  virtual void AddObserver(SyncNotifierObserver* observer) = 0;
+  virtual void RemoveObserver(SyncNotifierObserver* observer) = 0;
+
+  virtual void Login(

[akalin, 2011/03/10 04:26:45]

See comment in syncapi.cc re. changing Login() to UpdateCredentials().

[Agrawal, 2011/03/11 01:13:07]

Done.

+      const std::string& email, const std::string& token,
+      const std::string& state) = 0;
+
+  virtual void UpdateEnabledTypes(const syncable::ModelTypeSet& types) = 0;
+  virtual void SendNotification(bool* notification_pending) = 0;

[akalin, 2011/03/10 04:26:45]

Is there a way to avoid having to send this bool?

[akalin, 2011/03/10 04:26:45]

Add a comment saying that this is here only to support the old p2p notification
implementation, which is still used by sync integration tests.  Add a
TODO(akalin) to remove this once we move the integration tests off p2p
notifications.

[Agrawal, 2011/03/11 01:13:07]

Done.

[Agrawal, 2011/03/11 01:13:07]

Done.

+};
+}  // namespace sync_notifier
+
+#endif  // CHROME_BROWSER_SYNC_NOTIFIER_SYNC_NOTIFIER_H_
+