Refactor sync notifier out of sync api.

chrome/browser/sync/notifier/sync_notifier.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+
+#ifndef CHROME_BROWSER_SYNC_NOTIFIER_SYNC_NOTIFIER_H_
+#define CHROME_BROWSER_SYNC_NOTIFIER_SYNC_NOTIFIER_H_
+
+#include "chrome/browser/sync/notifier/sync_notifier_callback.h"
+#include "chrome/browser/sync/syncable/model_type.h"
+
+namespace sync_notifier {
+
+class SyncNotifier {
+ public:
+  virtual void Login(

[akalin, 2011/03/08 02:48:30]

have a public virtual destructor

[Agrawal, 2011/03/08 23:07:28]

Done. Thanks for pointing out.

+      const std::string& email, const std::string& token,

[akalin, 2011/03/08 02:48:30]

need #include string

[Agrawal, 2011/03/08 23:07:28]

Done.

+      const std::string& state,
+      SyncNotifierCallback* sync_notifier_callback) = 0;

[akalin, 2011/03/08 02:48:30]

I think that instead of bundling SyncNotifierCallback into Login, there should
be separate functions:

void AddObserver(SyncNotifierCallback*);
void RemoveObserver(SyncNotifierCallback*);

I think decoupling delegate/observer setting from initialization makes the class
easier to test/work with, and eventually I may want to attach javascript
listeners to the notifier (for about:sync), so supporting multiple observers
would be nice.  ObserverList should make this easy.

[Agrawal, 2011/03/09 01:57:04]

Done. Thanks for the suggestion.

+
+  virtual void UpdateEnabledTypes(const syncable::ModelTypeSet& types) = 0;
+  virtual void Logout() = 0;

[akalin, 2011/03/08 02:48:30]

I think there's no need for an explicit Logout() interface -- we can just have
the destructor do the work.

[Agrawal, 2011/03/09 01:57:04]

Done.

+};
+}  // namespace sync_notifier
+
+#endif  // CHROME_BROWSER_SYNC_NOTIFIER_SYNC_NOTIFIER_H_
+