Issue 6621052: Remove unused memory usage collection in MetricsService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6621052: Remove unused memory usage collection in MetricsService (Closed)

Created:
9 years, 9 months ago by sail

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, viettrungluu, jar (doing other things)

CC:
chromium-reviews, stuartmorgan

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Remove unused memory usage collection in MetricsService MetricsService was calling MemoryDetails::StartFetch but wasn't using the result so I'm removing the call entirely. BUG=43207 TEST=None

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -38 lines)			Patch
	M	chrome/browser/metrics/metrics_service.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	chrome/browser/metrics/metrics_service.cc	View		5 chunks	+7 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

9 years, 8 months ago (2011-04-19 17:18:31 UTC) #4

Please explain why you removed this call.  The call was historically made for
side effects to load histogram data.  I would expect this CL to have vanquished
our memory histograms, by not recording data.

When choosing reviewers, please be sure to use svn blame to find folks that
created or recently edited code that you are changing.

When you look at a call, and see the return value is "not used," you can't
assume the call can be discarded.  If that were true, we could rip out calls to
all functions that return void.

I'm also sad that this was not linked to your landing (it does not show as being
committed).  As a result, it is more painful to track what was landed and when.

Assuming you don't have a clean replacement that gathers the memory stats (I
didn't see it in this CL), please revert this change ASAP, and go though the
regular review process for a change (and I'd be pleased to review such a
change).

Expand Messages | Collapse Messages