Issue 6621043: When listing things for pruning, include anything that has an override depend...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6621043: When listing things for pruning, include anything that has an override depend... (Closed)

Created:
9 years, 9 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

Description

When listing things for pruning, include anything that has an override dependency of None. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77284

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gclient.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

9 years, 9 months ago (2011-03-08 13:43:24 UTC) #2

lgtm with less characters.

http://codereview.chromium.org/6621043/diff/1/gclient.py
File gclient.py (right):

http://codereview.chromium.org/6621043/diff/1/gclient.py#newcode737
gclient.py:737: entries = [i.name for i in self.tree(False) if i.url != None]
"if i.url" would be sufficient. I think it's fine to assume '' and None has the
same behavior?

For instance in run() at line 348, it uses if run_scm and self.parsed_url so ''
will have the same effect as None.

I'm not 100% sure though because LateOverride() has a different code path
depending if the url is a string or a None object. I guess if url == '', it's
just currently broken. In any case to stay safe it'd drop the "!= None".

Expand Messages | Collapse Messages