Ensure the result is used for the remaining calls to SetElement...

Ensure the result is used for the remaining calls to SetElement

Now mark SetElement as must use result

The debugger runs inside its own context so there should be no setters hit. Which is the reason for the live-edit code asserting non-empty handles.

Committed: http://code.google.com/p/v8/source/detail?r=7088

[Lasse Reichstein, 2011-03-08 09:26:07]

LGTM

http://codereview.chromium.org/6621042/diff/1/src/debug.cc
File src/debug.cc (right):

http://codereview.chromium.org/6621042/diff/1/src/debug.cc#newcode1007
src/debug.cc:1007: // they are in a FixedArray.
The second part of the comment should maybe be moved to just before line 1011
for a better context.

http://codereview.chromium.org/6621042/diff/1/src/handles.h
File src/handles.h (right):

http://codereview.chromium.org/6621042/diff/1/src/handles.h#newcode270
src/handles.h:270: StrictModeFlag strict_mode);
Yey!

http://codereview.chromium.org/6621042/diff/1/src/liveedit.cc
File src/liveedit.cc (right):

http://codereview.chromium.org/6621042/diff/1/src/liveedit.cc#newcode290
src/liveedit.cc:290: no_failure = SetElement(array_,
Add a comment saying that we never set element accessors in the debug context.

http://codereview.chromium.org/6621042/diff/1/src/liveedit.cc#newcode303
src/liveedit.cc:303: kNonStrictMode);
Are we sure we don't get any warnings from this assignment in release mode? On
any platform? The assigned value is unused.

[Peter Rybin, 2011-03-09 18:07:29]

On 2011/03/07 14:24:16, Søren Gjesse wrote:

Thanks for adding me in CC.
Sorry, couldn't answered earlier, I was on vacation.

Peter