Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: remoting/client/plugin/chromoting_instance.h

Issue 6621018: Convert Chromoting plugin logging to appear in client UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | remoting/client/plugin/chromoting_instance.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ajwong): We need to come up with a better description of the 5 // TODO(ajwong): We need to come up with a better description of the
6 // responsibilities for each thread. 6 // responsibilities for each thread.
7 7
8 #ifndef REMOTING_CLIENT_PLUGIN_CHROMOTING_INSTANCE_H_ 8 #ifndef REMOTING_CLIENT_PLUGIN_CHROMOTING_INSTANCE_H_
9 #define REMOTING_CLIENT_PLUGIN_CHROMOTING_INSTANCE_H_ 9 #define REMOTING_CLIENT_PLUGIN_CHROMOTING_INSTANCE_H_
10 10
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 virtual bool CurrentlyOnPluginThread() const; 70 virtual bool CurrentlyOnPluginThread() const;
71 71
72 // Convenience wrapper to get the ChromotingScriptableObject. 72 // Convenience wrapper to get the ChromotingScriptableObject.
73 ChromotingScriptableObject* GetScriptableObject(); 73 ChromotingScriptableObject* GetScriptableObject();
74 74
75 // Called by ChromotingScriptableObject to provide username and password. 75 // Called by ChromotingScriptableObject to provide username and password.
76 void SubmitLoginInfo(const std::string& username, 76 void SubmitLoginInfo(const std::string& username,
77 const std::string& password); 77 const std::string& password);
78 78
79 void LogDebugInfo(const std::string& info); 79 void LogDebugInfo(const std::string& info);
80 void LogDebugWarning(const std::string& info);
Sergey Ulanov 2011/03/04 22:28:45 Looks like these three methods can be replaced wit
dmac 2011/03/05 00:52:01 and can we make them void LogDebug(Severity, forma
81 void LogDebugError(const std::string& info);
80 82
81 private: 83 private:
82 FRIEND_TEST_ALL_PREFIXES(ChromotingInstanceTest, TestCaseSetup); 84 FRIEND_TEST_ALL_PREFIXES(ChromotingInstanceTest, TestCaseSetup);
83 85
84 // Since we're an internal plugin, we can just grab the message loop during 86 // Since we're an internal plugin, we can just grab the message loop during
85 // init to figure out which thread we're on. This should only be used to 87 // init to figure out which thread we're on. This should only be used to
86 // sanity check which thread we're executing on. Do not post task here! 88 // sanity check which thread we're executing on. Do not post task here!
87 // Instead, use PPB_Core:CallOnMainThread() in the pepper api. 89 // Instead, use PPB_Core:CallOnMainThread() in the pepper api.
88 // 90 //
89 // TODO(ajwong): Think if there is a better way to safeguard this. 91 // TODO(ajwong): Think if there is a better way to safeguard this.
(...skipping 18 matching lines...) Expand all
108 // JavaScript interface to control this instance. 110 // JavaScript interface to control this instance.
109 // This wraps a ChromotingScriptableObject in a pp::Var. 111 // This wraps a ChromotingScriptableObject in a pp::Var.
110 pp::Var instance_object_; 112 pp::Var instance_object_;
111 113
112 DISALLOW_COPY_AND_ASSIGN(ChromotingInstance); 114 DISALLOW_COPY_AND_ASSIGN(ChromotingInstance);
113 }; 115 };
114 116
115 } // namespace remoting 117 } // namespace remoting
116 118
117 #endif // REMOTING_CLIENT_PLUGIN_CHROMOTING_INSTANCE_H_ 119 #endif // REMOTING_CLIENT_PLUGIN_CHROMOTING_INSTANCE_H_
OLDNEW
« no previous file with comments | « no previous file | remoting/client/plugin/chromoting_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698