utility/dump_fmap.c - Issue 6621003: Don't prepend 'fmap.' to section names. It will break the Cr-48 installer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utility/dump_fmap.c

Issue 6621003: Don't prepend 'fmap.' to section names. It will break the Cr-48 installer. (Closed) Base URL: http://git.chromium.org/git/vboot_reference.git@master

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: utility/dump_fmap.c

diff --git a/utility/dump_fmap.c b/utility/dump_fmap.c

index bd7abac9481a40cc4b5d932493f1628fe8efdf93..ab2043c8bb26d0ce4a50fc80acc8f160a9e5faaf 100644

--- a/utility/dump_fmap.c

+++ b/utility/dump_fmap.c

@@ -57,7 +57,8 @@ static int dump_fmap(const void* ptr) {

progname, buf, strerror(errno));

retval = 1;

} else {

- if (1 != fwrite(base_of_rom + ah->area_offset, ah->area_size, 1, fp)) {

+ if (ah->area_size &&

+ 1 != fwrite(base_of_rom + ah->area_offset, ah->area_size, 1, fp)) {

fprintf(stderr, "%s: can't write %s: %s\n",

progname, buf, strerror(errno));

retval = 1;

« no previous file with comments | « utility/dev_debug_vboot ('k') | no next file » | no next file with comments »