Stream speech audio to server as it gets recorded, instead of waiting until end of recording.

content/browser/speech/speech_recognizer_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "chrome/common/net/test_url_fetcher_factory.h"
 #include "content/browser/browser_thread.h"
 #include "content/browser/speech/speech_recognizer.h"
 #include "media/audio/test_audio_input_controller_factory.h"
@@ skipping 120 matching lines @@
 
 TEST_F(SpeechRecognizerTest, StopWithData) {
   // Start recording, give some data and then stop. This should wait for the
   // network callback to arrive before completion.
   EXPECT_TRUE(recognizer_->StartRecording());
   TestAudioInputController* controller =
       audio_input_controller_factory_.controller();
   ASSERT_TRUE(controller);
   controller = audio_input_controller_factory_.controller();
   ASSERT_TRUE(controller);
-  controller->event_handler()->OnData(controller, &audio_packet_[0],
-                                      audio_packet_.size());
-  MessageLoop::current()->RunAllPending();
+
+  // Try sending 5 chunks of mock audio data and verify that each of them
+  // resulted immediately in a packet sent out via the network. This verifies
+  // that we are streaming out encoded data as chunks without waiting for the
+  // full recording to complete.
+  const size_t kNumChunks = 5;
+  for (size_t i = 0; i < kNumChunks; ++i) {
+    controller->event_handler()->OnData(controller, &audio_packet_[0],
+                                        audio_packet_.size());
+    MessageLoop::current()->RunAllPending();
+    TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
+    ASSERT_TRUE(fetcher);
+    EXPECT_EQ(i + 1, fetcher->upload_chunks().size());
+  }
+
   recognizer_->StopRecording();
   EXPECT_TRUE(recording_complete_);
   EXPECT_FALSE(recognition_complete_);
   EXPECT_FALSE(result_received_);
   EXPECT_EQ(SpeechRecognizer::RECOGNIZER_NO_ERROR, error_);
 
   // Issue the network callback to complete the process.
   TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
   ASSERT_TRUE(fetcher);
   net::URLRequestStatus status;
   status.set_status(net::URLRequestStatus::SUCCESS);
   fetcher->delegate()->OnURLFetchComplete(
       fetcher, fetcher->original_url(), status, 200, ResponseCookies(),
       "{\"hypotheses\":[{\"utterance\":\"123\"}]}");
   EXPECT_TRUE(recognition_complete_);
   EXPECT_TRUE(result_received_);
   EXPECT_EQ(SpeechRecognizer::RECOGNIZER_NO_ERROR, error_);
 }
 
 TEST_F(SpeechRecognizerTest, CancelWithData) {
-  // Start recording, give some data and then cancel. This should not create
-  // a network request and finish immediately.
+  // Start recording, give some data and then cancel. This should create
+  // a network request but give no callbacks.
   EXPECT_TRUE(recognizer_->StartRecording());
   TestAudioInputController* controller =
       audio_input_controller_factory_.controller();
   ASSERT_TRUE(controller);
   controller->event_handler()->OnData(controller, &audio_packet_[0],
                                       audio_packet_.size());
   MessageLoop::current()->RunAllPending();
   recognizer_->CancelRecognition();
-  EXPECT_EQ(NULL, url_fetcher_factory_.GetFetcherByID(0));
+  ASSERT_TRUE(url_fetcher_factory_.GetFetcherByID(0));
   EXPECT_FALSE(recording_complete_);
   EXPECT_FALSE(recognition_complete_);
   EXPECT_FALSE(result_received_);
   EXPECT_EQ(SpeechRecognizer::RECOGNIZER_NO_ERROR, error_);
 }
 
 TEST_F(SpeechRecognizerTest, AudioControllerErrorNoData) {
   // Check if things tear down properly if AudioInputController threw an error.
   EXPECT_TRUE(recognizer_->StartRecording());
   TestAudioInputController* controller =
@@ skipping 11 matching lines @@
   // Check if things tear down properly if AudioInputController threw an error
   // after giving some audio data.
   EXPECT_TRUE(recognizer_->StartRecording());
   TestAudioInputController* controller =
       audio_input_controller_factory_.controller();
   ASSERT_TRUE(controller);
   controller->event_handler()->OnData(controller, &audio_packet_[0],
                                       audio_packet_.size());
   controller->event_handler()->OnError(controller, 0);
   MessageLoop::current()->RunAllPending();
-  EXPECT_EQ(NULL, url_fetcher_factory_.GetFetcherByID(0));
+  ASSERT_TRUE(url_fetcher_factory_.GetFetcherByID(0));
   EXPECT_FALSE(recording_complete_);
   EXPECT_FALSE(recognition_complete_);
   EXPECT_FALSE(result_received_);
   EXPECT_EQ(SpeechRecognizer::RECOGNIZER_ERROR_CAPTURE, error_);
 }
 
 TEST_F(SpeechRecognizerTest, NoSpeechCallbackIssued) {
   // Start recording and give a lot of packets with audio samples set to zero.
   // This should trigger the no-speech detector and issue a callback.
   EXPECT_TRUE(recognizer_->StartRecording());
@@ skipping 87 matching lines @@
   EXPECT_FLOAT_EQ(0.81907868f, volume_);
   EXPECT_FLOAT_EQ(0.52143687f, noise_volume_);
 
   EXPECT_EQ(SpeechRecognizer::RECOGNIZER_NO_ERROR, error_);
   EXPECT_FALSE(recording_complete_);
   EXPECT_FALSE(recognition_complete_);
   recognizer_->CancelRecognition();
 }
 
 }  // namespace speech_input