Change the translation of polymorphic stores.

Change the translation of polymorphic stores.

They do not use subgraphs or subgraph scopes.  Instead of computing a list
of single-block subgraphs and then adding all the edges afterward, build
both the blocks and edges directly.

Committed: http://code.google.com/p/v8/source/detail?r=7058

[Kevin Millikin (Chromium), 2011-03-03 14:59:24]

Request for comment.  If you like it I'll do the same to the other polymorphic
variants.  It doesn't use the helper BuildTypeSwitch at all, but it's not much
more code than it was before.

Once the others are rewritten I'll look for some common pattern that might be
useful to share.

[fschneider, 2011-03-03 16:59:57]

I like the approach. I saved the temporary ZoneLists and the code for
polymorphic loads can probably share a lot. I think it's fine to have a separate
helper to handle polymorphic calls since they don't fit the same pattern.

http://codereview.chromium.org/6615014/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/6615014/diff/1/src/hydrogen.cc#newcode3183
src/hydrogen.cc:3183: HInstruction* instr = BuildStoreNamedGeneric(object, name,
value);
Maybe BuildStoreNamedGeneric should return a HStoreNamedGeneric*, and
instr->HasSideEffect() will be always true.

[fschneider, 2011-03-03 17:01:05]

On 2011/03/03 16:59:57, fschneider wrote:
> I like the approach. I saved the temporary ZoneLists and the code for

------------> I meant "It saves"

[Mads Ager (chromium), 2011-03-03 22:19:14]

Looks nice. I like it too.