Issue 6615012: Mark HChange that convert to int32 with truncation with the appropiate flag....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6615012: Mark HChange that convert to int32 with truncation with the appropiate flag.... (Closed)

Created:
9 years, 9 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Mark HChange that convert to int32 with truncation with the appropiate flag. Before we would compute the flag by iterating over all uses. The truncating flag is always determined at construction time since we already computed the flag for all other instructions before inserting HChange instructions. Committed: http://code.google.com/p/v8/source/detail?r=7047

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -17 lines)			Patch
M	src/hydrogen.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/hydrogen.cc	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	3 chunks	+5 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages