Issue 661470: Change heap sort of descriptor array to bottom-up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661470: Change heap sort of descriptor array to bottom-up. (Closed)

Created:
10 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change heap sort of descriptor array to bottom-up. Committed: http://code.google.com/p/v8/source/detail?r=4013

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -25 lines)			Patch
	M	src/objects.cc	View	1	2 chunks	+32 lines, -25 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 9 months ago (2010-03-04 08:24:40 UTC) #2

STV!

http://codereview.chromium.org/661470/diff/4/5
File src/objects.cc (right):

http://codereview.chromium.org/661470/diff/4/5#newcode3434
src/objects.cc:3434: const int max_parent_index = len/2 - 1;
Space around binary operations and use parens for clearity.

http://codereview.chromium.org/661470/diff/4/5#newcode3462
src/objects.cc:3462: const int max_parent_index = i/2 - 1;
Ditto.

Expand Messages | Collapse Messages