Issue 661468: - Changed the initial size for HashTable....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661468: - Changed the initial size for HashTable.... (Closed)

Created:
10 years, 9 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Changed the initial size for HashTable. - Pretenured large expanding hash tables. Committed: http://code.google.com/p/v8/source/detail?r=4010

Patch Set 1 #

Total comments: 4

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -12 lines)			Patch
M	src/heap.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/heap.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.cc	View	2 chunks	+14 lines, -8 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/661468/diff/1/3 File src/objects.cc (right): http://codereview.chromium.org/661468/diff/1/3#newcode6949 src/objects.cc:6949: // 25% is still free after adding n ...

10 years, 9 months ago (2010-03-03 16:01:05 UTC) #2

bak

10 years, 9 months ago (2010-03-03 16:18:26 UTC) #3

//Lars

http://codereview.chromium.org/661468/diff/1/3
File src/objects.cc (right):

http://codereview.chromium.org/661468/diff/1/3#newcode6949
src/objects.cc:6949: //   25% is still free after adding n elements and
On 2010/03/03 16:01:06, Kasper Lund wrote:
> Update comment to reflect 50%.

Done.

http://codereview.chromium.org/661468/diff/1/3#newcode6956
src/objects.cc:6956: const int kMinCapacityForPreTenure = 256;
On 2010/03/03 16:01:06, Kasper Lund wrote:
> PreTenure -> Pretenure (to match the rest of the code). Maybe this should be
> kMaxCapacityForNonTenured? You can have pretenured hash tables with a smaller
> capacity than this.
I changed the uppercase issue.

Expand Messages | Collapse Messages