Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 661467: [Linux] Patch LogSharedLibraryAddresses to work correctly on Android. (Closed)

Created:
10 years, 9 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

[Linux] Patch LogSharedLibraryAddresses to work correctly on Android. On 'usual' Linux systems in '/proc/self/maps' we encounter two entries per library: one has 'rw-p' attrs and the other has 'r-xp'. While on Android, I see 'rwxp' and 'r-xp' (both entries are marked executable.) So I've added an explicit check for non-writability to leave only a single record in the log file. Committed: http://code.google.com/p/v8/source/detail?r=4018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/platform-linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
10 years, 9 months ago (2010-03-03 15:35:50 UTC) #1
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-04 07:59:27 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698