Issue 661466: Fix broken test in WebKit test suite and add the test in question to V8 tests...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661466: Fix broken test in WebKit test suite and add the test in question to V8 tests... (Closed)

Created:
10 years, 9 months ago by Oleg Eterevsky

Modified:
9 years, 5 months ago

Reviewers:
antonm, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix broken test in WebKit test suite and add the test in question to V8 tests. Committed: http://code.google.com/p/v8/source/detail?r=4009

Patch Set 3 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -3 lines)			Patch
	M	src/runtime.cc	View	1 2	1 chunk	+19 lines, -3 lines	0 comments	Download
	M	test/mjsunit/date.js	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/661466/diff/5/6 File src/runtime.cc (right): http://codereview.chromium.org/661466/diff/5/6#newcode4981 src/runtime.cc:4981: static const int base_day = 365*(1970 + year_delta) ...

10 years, 9 months ago (2010-03-03 14:09:37 UTC) #2

Oleg Eterevsky

10 years, 9 months ago (2010-03-03 14:18:18 UTC) #3

http://codereview.chromium.org/661466/diff/5/6
File src/runtime.cc (right):

http://codereview.chromium.org/661466/diff/5/6#newcode4981
src/runtime.cc:4981: static const int base_day = 365*(1970 + year_delta) + (1970
+ year_delta)/4 -
On 2010/03/03 14:09:37, Mads Ager wrote:
> Please add space around all binary operations in this code.

Done.

Expand Messages | Collapse Messages

Issue 661466: Fix broken test in WebKit test suite and add the test in question to V8 tests... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages