Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/ia32/virtual-frame-ia32.cc

Issue 661461: Remove a duplicated move instruction for store IC calls on ia32. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 919 matching lines...) Expand 10 before | Expand all | Expand 10 after
930 930
931 Result VirtualFrame::CallStoreIC(Handle<String> name, bool is_contextual) { 931 Result VirtualFrame::CallStoreIC(Handle<String> name, bool is_contextual) {
932 // Value and (if not contextual) receiver are on top of the frame. 932 // Value and (if not contextual) receiver are on top of the frame.
933 // The IC expects name in ecx, value in eax, and receiver in edx. 933 // The IC expects name in ecx, value in eax, and receiver in edx.
934 Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize)); 934 Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize));
935 Result value = Pop(); 935 Result value = Pop();
936 if (is_contextual) { 936 if (is_contextual) {
937 PrepareForCall(0, 0); 937 PrepareForCall(0, 0);
938 value.ToRegister(eax); 938 value.ToRegister(eax);
939 __ mov(edx, Operand(esi, Context::SlotOffset(Context::GLOBAL_INDEX))); 939 __ mov(edx, Operand(esi, Context::SlotOffset(Context::GLOBAL_INDEX)));
940 __ mov(ecx, name);
941 value.Unuse(); 940 value.Unuse();
942 } else { 941 } else {
943 Result receiver = Pop(); 942 Result receiver = Pop();
944 PrepareForCall(0, 0); 943 PrepareForCall(0, 0);
945 MoveResultsToRegisters(&value, &receiver, eax, edx); 944 MoveResultsToRegisters(&value, &receiver, eax, edx);
946 } 945 }
947 __ mov(ecx, name); 946 __ mov(ecx, name);
948 return RawCallCodeObject(ic, RelocInfo::CODE_TARGET); 947 return RawCallCodeObject(ic, RelocInfo::CODE_TARGET);
949 } 948 }
950 949
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
1177 return; 1176 return;
1178 } 1177 }
1179 1178
1180 UNREACHABLE(); 1179 UNREACHABLE();
1181 } 1180 }
1182 1181
1183 1182
1184 #undef __ 1183 #undef __
1185 1184
1186 } } // namespace v8::internal 1185 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698