Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 661460: Uses the new spellchecker dictionaries on Chromium. (Closed)

Created:
10 years, 9 months ago by Hironori Bono
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, jam+cc_chromium.org, brettw+cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Uses the new spellchecker dictionaries on Chromium. This change enables Chromium users to use the new spellchecker dictionaries added by r39400, r40614, and r41000. This change also adds a unit test for Hungarian and rebaselines the unit test for Romanian. As written in Issue 33024, the correct Romanian characters are U+0219 and U+021B even though our old Romanian dictionary uses U+015F and U+0163. So, this change rebaselined to use the correct Romanian characters. BUG=8397, 15558, 33024 TEST=unit_test.exe --gtest_filter=SpellCheckTest.SpellCheckText Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41562

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M chrome/common/spellcheck_common.cc View 2 3 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 1 2 3 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Stade
assuming green trybot results, LGTM
10 years, 9 months ago (2010-03-03 19:20:45 UTC) #1
Hironori Bono
Sorry for my slow update. I have finally verified the new spellchecker dictionaries work without ...
10 years, 9 months ago (2010-03-12 07:24:43 UTC) #2
Evan Stade
10 years, 9 months ago (2010-03-12 19:35:26 UTC) #3
awesome, LG!

Powered by Google App Engine
This is Rietveld 408576698