Issue 661447: First version of the new devserver client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661447: First version of the new devserver client (Closed)

Created:
10 years, 9 months ago by rtc

Modified:
9 years, 7 months ago

Reviewers:
seano, adlr

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

First version of the new devserver client

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -117 lines)			Patch
M	src/platform/dev/buildutil.py	View	1 chunk	+0 lines, -101 lines	0 comments	Download
M	src/platform/dev/devserver.py	View	3 chunks	+6 lines, -16 lines	0 comments	Download
A	src/platform/dev/gmerge	View	1 chunk	+38 lines, -0 lines	1 comment	Download
A	src/platform/dev/static/pkgroot	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ comment http://codereview.chromium.org/661447/diff/1/4 File src/platform/dev/gmerge (right): http://codereview.chromium.org/661447/diff/1/4#newcode29 src/platform/dev/gmerge:29: ESCAPED_BOARD=$(python -c "import urllib; print urllib.quote('''${BOARD_NAME}''')") ...

10 years, 9 months ago (2010-03-03 05:07:26 UTC) #2

lgtm

Expand Messages | Collapse Messages