Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 6614029: Add ability to pass a base test root and create results dirs relative. (Closed)

Created:
9 years, 9 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
dgarrett
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add ability to pass a base test root and create results dirs relative. Sets up dir paths as follows: test_root/test_name i.e. SimpleUpdate/<num>_stage For example: test_root/testNormalUpdateKeepStateful/2_verify/...test_results... corresponds to the second invocation of verify image. The test results for this stage are stored here. This is a predecessor for storing arbitrary logs e.g. update into this test results root. Change-Id: I7183420b5dcb0d6971aa508a338c048c3557e359 BUG=chromium-os:12211 TEST=With simple a full vm test suite w/ w/out explicit test root set. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b54301b

Patch Set 1 #

Patch Set 2 : WS #

Patch Set 3 : Add ctest flag as well #

Total comments: 2

Patch Set 4 : ws #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -11 lines) Patch
M bin/au_test_harness/au_test.py View 1 11 chunks +21 lines, -2 lines 0 comments Download
M bin/au_test_harness/au_worker.py View 1 3 chunks +22 lines, -2 lines 0 comments Download
M bin/au_test_harness/cros_au_test_harness.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M bin/au_test_harness/dummy_au_worker.py View 1 chunk +2 lines, -2 lines 0 comments Download
M bin/au_test_harness/real_au_worker.py View 2 chunks +4 lines, -2 lines 0 comments Download
M bin/au_test_harness/vm_au_worker.py View 3 chunks +4 lines, -2 lines 0 comments Download
M bin/ctest.py View 1 2 4 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sosa
For some reason I thought I published this yesterday.
9 years, 9 months ago (2011-03-04 18:48:13 UTC) #1
sosa
Added test_results_root to ctest as well.
9 years, 9 months ago (2011-03-04 19:14:42 UTC) #2
dgarrett
9 years, 9 months ago (2011-03-04 22:31:12 UTC) #3
LGTM with a couple of notes.

http://codereview.chromium.org/6614029/diff/3001/bin/au_test_harness/cros_au_...
File bin/au_test_harness/cros_au_test_harness.py (right):

http://codereview.chromium.org/6614029/diff/3001/bin/au_test_harness/cros_au_...
bin/au_test_harness/cros_au_test_harness.py:253: if leftover_args:
parser.error('Found unsupported flags: % s' % leftover_args)
I think that space is put there by mistake, though it seems to have no effect
for non-integers.

http://codereview.chromium.org/6614029/diff/3001/bin/au_test_harness/cros_au_...
bin/au_test_harness/cros_au_test_harness.py:265: error_msg = ('Could not find %
s key.  Both private and public keys must be '
80 characters, the space looks like an error, and there is nothing %'d into the
%s anyway.

Powered by Google App Engine
This is Rietveld 408576698